Skip to content

Fix piechart large arc #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2019
Merged

Fix piechart large arc #181

merged 2 commits into from
May 22, 2019

Conversation

@thomas-oo
Copy link

@thomas-oo thomas-oo commented Jun 8, 2018

Explanation About What Code Achieves:
Screenshots/GIFs:
  • Screenshot
Steps To Test:
  • Steps
TODOs:
  • None

Ricardo Marino and others added 2 commits April 17, 2018 17:45
Fix for issue frappe#108
2286848 
Piechart could not render large arcs (>180) properly because the
information of large arc was not provided to the SVG drawing
function. This was fixed, and the piechart should render
correctly when one slice is larger than 180 degrees.
Merge branch 'master' of https://github.com/frappe/charts into Fix_pi…
582936e 
…echart_large_arc
@coveralls
Copy link

coveralls commented Jun 8, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 69

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.158%
Totals Coverage Status
Change from base Build 66: 0.0%
Covered Lines: 29
Relevant Lines: 62
💛 - Coveralls

@thomas-oo thomas-oo mentioned this pull request Jun 8, 2018
Closed
@scmmishra scmmishra merged commit ef72925 into frappe:master May 22, 2019
@scmmishra scmmishra mentioned this pull request May 24, 2019
Closed
This was referenced Jul 20, 2019
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@scmmishra scmmishra scmmishra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pie chart display issue.

3 participants

@thomas-oo @coveralls @scmmishra