fix(phpfatalerror): fixed uncaught error to member function getRisk()

ritankarsaha · ritankarsaha · commit cf2755657069 · 2025-04-19T02:12:20.000+05:30
changes

Signed-off-by: Ritankar Saha &lt;ritankar.saha786@gmail.com&gt;

php space fixes

Signed-off-by: Ritankar Saha &lt;ritankar.saha786@gmail.com&gt;
diff --git a/src/lib/php/Report/LicenseMainGetter.php b/src/lib/php/Report/LicenseMainGetter.php
@@ -39,13 +39,17 @@ protected function getStatements($uploadId, $uploadTreeTableName, $groupId = nul
     $allStatements = array();
     foreach ($mainLicIds as $originLicenseId) {
       $allLicenseCols = $this->licenseDao->getLicenseById($originLicenseId, $groupId);
+      // Null-check: if the license is missing, log and skip this ID.
+      if ($allLicenseCols === null) {
+        error_log("Warning: License ID " . $originLicenseId . " not found in the database.");
+        continue;
+      }
       $allStatements[] = array(
         'licenseId' => $originLicenseId,
         'risk' => $allLicenseCols->getRisk(),
         'content' => $licenseMap->getProjectedSpdxId($originLicenseId),
         'text' => $allLicenseCols->getText(),
-        'name' => $licenseMap->getProjectedShortname($originLicenseId,
-            $allLicenseCols->getShortName())
+        'name' => $licenseMap->getProjectedShortname($originLicenseId, $allLicenseCols->getShortName())
       );
     }
     return $allStatements;
diff --git a/src/spdx/agent/spdx.php b/src/spdx/agent/spdx.php
@@ -224,23 +224,24 @@ function processUploadId($uploadId)
     }
     $this->licenseMap = new LicenseMap($this->dbManager, $this->groupId, LicenseMap::REPORT, true);
     $this->computeUri($uploadId);
-
     $docLicense = $this->licenseDao->getLicenseByShortName(self::DATA_LICENSE);
+    if ($docLicense === null) {
+      error_log("Warning: License with short name " . self::DATA_LICENSE . " not found in the database. Using fallback license.");
+      $docLicense = new License(0, self::DATA_LICENSE, "Fallback License", "Unknown", "No license text available", "", "", "");
+    }
     $docLicenseId = $docLicense->getId() . "-" . md5($docLicense->getText());
     $this->licensesInDocument[$docLicenseId] = (new SpdxLicenseInfo())
       ->setLicenseObj($docLicense)
       ->setListedLicense(true)
       ->setCustomText(false)
       ->setTextPrinted(true);
-
     $packageNodes = $this->renderPackage($uploadId);
     $additionalUploadIds = array_key_exists(self::UPLOAD_ADDS,$args) ? explode(',',$args[self::UPLOAD_ADDS]) : array();
     $packageIds = array($uploadId);
     foreach ($additionalUploadIds as $additionalId) {
       $packageNodes .= $this->renderPackage($additionalId);
       $packageIds[] = $additionalId;
     }
-
     $this->writeReport($packageNodes, $packageIds, $uploadId);
     return true;
   }
