Skip to content

Conversation

@mgaitan
Copy link

@mgaitan mgaitan commented Jun 24, 2014

I've added a basic setup.py to made this software easily installable and distributable.
Note I moved the code to a package called tiling, so the canonical from tile turns into from tiling

Also uses the pycairo drop-in replace cairocffi which is much more easy to install and better documented (pycairo can't be installed via pip/ inside a virtualenv)

you should register and upload it to pypi. See this

@fogleman
Copy link
Owner

fogleman commented Jul 1, 2014

  1. Are all of those .gitignore lines needed? Looks like a template. I'd prefer only listing things that are needed for this project.
  2. I think main.py should remain outside of the package itself.

@mgaitan
Copy link
Author

mgaitan commented Jul 5, 2014

@fogleman I've just done the change you requested. But let me ask: what's the purpose of main.py? It's just for testing against regressions? couldn't we convert it as a testcase, comparing the dynamically generated images against know ones?

@mgaitan
Copy link
Author

mgaitan commented Aug 19, 2014

@fogleman: this is polite reminder to review this PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants