Skip to content

Conversation

@segfault3
Copy link

Please confirm your submission meets all the criteria

@github-actions github-actions bot added the awaiting-review Pull requests waiting for review label Dec 15, 2025
@github-actions
Copy link

Starting a test build of the submission. Please fix any
issues reported in the build log. You can restart the build
once the issue is fixed by commenting the phrase below.

bot, build

@flathubbot
Copy link

🚧 Test build enqueued.

@flathubbot
Copy link

🚧 Started test build.

@flathubbot
Copy link

Test build failed.

Help
  • bot, build - Restart the test build

@segfault3
Copy link
Author

Error: 'appid-url-not-reachable' error found in linter manifest check. Details: Tried https://gitlab.com/MetadataCleaner/MetadataCleaner | Status: 301 | Body: You are being redirected.

I've already seen that error locally when using the linter, but I was hoping that it's not a blocker that the app ID uses uppercase. The URL https://gitlab.com/MetadataCleaner/MetadataCleaner redirects to https://gitlab.com/metadatacleaner/metadatacleaner which I have control over.

@hfiguiere
Copy link
Contributor

it's a blocker. make it match. all lowercase is 100% fine.

@segfault3 segfault3 force-pushed the metadatacleaner-submission branch 2 times, most recently from 53d1948 to c4f335d Compare December 15, 2025 17:39
@segfault3 segfault3 changed the title Add io.gitlab.MetadataCleaner.MetadataCleaner Add io.gitlab.metadatacleaner.metadatacleaner Dec 15, 2025
@segfault3
Copy link
Author

bot, build

@flathubbot
Copy link

🚧 Test build enqueued.

@flathubbot
Copy link

🚧 Started test build.

@flathubbot
Copy link

Test build failed.

Help
  • bot, build - Restart the test build

@segfault3 segfault3 force-pushed the metadatacleaner-submission branch from c4f335d to a949a4f Compare December 15, 2025 17:55
@segfault3
Copy link
Author

bot, build

@flathubbot
Copy link

🚧 Test build enqueued.

@flathubbot
Copy link

🚧 Started test build.

@flathubbot
Copy link

Test build failed.

Help
  • bot, build - Restart the test build

@segfault3 segfault3 force-pushed the metadatacleaner-submission branch from a949a4f to cc6a91d Compare December 15, 2025 18:43
@segfault3
Copy link
Author

bot, build

@flathubbot
Copy link

🚧 Test build enqueued.

@flathubbot
Copy link

🚧 Started test build.

@flathubbot
Copy link

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/236897/io.gitlab.metadatacleaner.metadatacleaner.flatpakref

Built for aarch64 and x86_64 architectures.

⚠️ Linter warnings:

Warnings can be promoted to errors in the future. Please try to resolve them.

  • 'appstream-screenshot-missing-caption' warning found in linter repo check. Details: One or more screenshots are missing captions in the Metainfo file

sources:
- type: git
url: https://github.com/Perl/perl5.git
tag: v5.40.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use 5.42.0 which is the same one that is in the SDK.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's in the SDK, do we even have to install it as a module? I tried to remove the module but then the installation of exiftool fails:

cp exiftool blib/script/exiftool
"/usr/bin/perl5.42.0" -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/exiftool
Manifying 1 pod document
Manifying 34 pod documents
Manifying 34 pod documents
Manifying 32 pod documents
Manifying 33 pod documents
Manifying 33 pod documents
Manifying 32 pod documents
Manifying 9 pod documents
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
ERROR: Can't create '/usr/bin'
Do not have write permissions on '/usr/bin'
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 at -e line 1.
make: *** [Makefile:1627: pure_site_install] Error 13
Error: module exiftool: Child process exited with code 2

I don't understand why installing Perl as a module avoids that error 🤔

Copy link
Contributor

@hfiguiere hfiguiere Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's in the SDK, do we even have to install it as a module?

It did NOT say to not add it, just to use the same version.

It's in the SDK but not in the platform.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, the Perl module was configured with -Dprefix=$FLATPAK_DEST

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now exiftool won't work. I never said to remove Perl from here. I just said to build 5.42.0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in the SDK but not in the platform.

ah, got it. I'll add it again.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@segfault3
Copy link
Author

bot, build

@flathubbot
Copy link

🚧 Test build enqueued.

@flathubbot
Copy link

🚧 Started test build.

@segfault3 segfault3 requested a review from hfiguiere December 15, 2025 23:13
@flathubbot
Copy link

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/236947/io.gitlab.metadatacleaner.metadatacleaner.flatpakref

Built for aarch64 and x86_64 architectures.

⚠️ Linter warnings:

Warnings can be promoted to errors in the future. Please try to resolve them.

  • 'appstream-screenshot-missing-caption' warning found in linter repo check. Details: One or more screenshots are missing captions in the Metainfo file

Copy link
Contributor

@hfiguiere hfiguiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@segfault3 segfault3 force-pushed the metadatacleaner-submission branch from 115e571 to 6a8b6a2 Compare December 15, 2025 23:16
@segfault3 segfault3 requested a review from hfiguiere December 15, 2025 23:16
@segfault3
Copy link
Author

bot, build

@flathubbot
Copy link

🚧 Test build enqueued.

@flathubbot
Copy link

🚧 Started test build.

@flathubbot
Copy link

Test build failed.

Help
  • bot, build - Restart the test build

@segfault3
Copy link
Author

bot, build

@flathubbot
Copy link

🚧 Test build enqueued.

@flathubbot
Copy link

🚧 Started test build.

@flathubbot
Copy link

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/236953/io.gitlab.metadatacleaner.metadatacleaner.flatpakref

Built for aarch64 and x86_64 architectures.

⚠️ Linter warnings:

Warnings can be promoted to errors in the future. Please try to resolve them.

  • 'appstream-screenshot-missing-caption' warning found in linter repo check. Details: One or more screenshots are missing captions in the Metainfo file

@bbhtt
Copy link
Contributor

bbhtt commented Dec 16, 2025

It was available on Flathub before but was removed after the original author stopped maintaining it.

So this is a fork? If so you have to use a different icon and name. And what changes was made in the fork?

@segfault3
Copy link
Author

So this is a fork?

Yes

If so you have to use a different icon and name.

I got the permission of the original author (via email) to use the original icon and name.

And what changes was made in the fork?

The only relevant changes (beside the ones to the Flatpak manifst which resulted from the review of this PR) are:

  • Change Flatpak app ID to remove the domain of the original author (as he requested).
  • Update Flatpak runtime and module sources to the latest releases

@bbhtt
Copy link
Contributor

bbhtt commented Dec 16, 2025

So not really a fork.

@segfault3
Copy link
Author

Depends on your definition of fork I guess. I don't have access to the original git repository, I'm maintaining the forked repo https://gitlab.com/metadatacleaner/metadatacleaner.

@segfault3
Copy link
Author

What's the status here? Is there a blocker? Can I do anything to move things forward?

@bbhtt
Copy link
Contributor

bbhtt commented Dec 22, 2025

I don't see a reason for a new submission with so minimal changes from the original project.

@segfault3
Copy link
Author

I don't understand. The original project is unmaintained and not available on Flathub anymore. Do you prefer that we add the original, unmaintained project again? Or that it's not available on Flathub at all?

@bbhtt
Copy link
Contributor

bbhtt commented Dec 23, 2025

Bottom line is, you can't submit a new app with the same name, icon and no code related changes in your fork as a new one.

If that means the app is not available then it's ok.

@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added pr-check-blocked Pull requests marked as blocked by automation and removed pr-check-blocked Pull requests marked as blocked by automation labels Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-changes Pull request waiting for inputs or changes from author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants