-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add io.gitlab.metadatacleaner.metadatacleaner #7323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: new-pr
Are you sure you want to change the base?
Conversation
|
Starting a test build of the submission. Please fix any bot, build |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
❌ Test build failed. Help
|
I've already seen that error locally when using the linter, but I was hoping that it's not a blocker that the app ID uses uppercase. The URL https://gitlab.com/MetadataCleaner/MetadataCleaner redirects to https://gitlab.com/metadatacleaner/metadatacleaner which I have control over. |
|
it's a blocker. make it match. all lowercase is 100% fine. |
53d1948 to
c4f335d
Compare
|
bot, build |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
❌ Test build failed. Help
|
c4f335d to
a949a4f
Compare
|
bot, build |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
❌ Test build failed. Help
|
Signed-off-by: segfault <[email protected]>
a949a4f to
cc6a91d
Compare
|
bot, build |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: Built for aarch64 and x86_64 architectures. Warnings can be promoted to errors in the future. Please try to resolve them.
|
| sources: | ||
| - type: git | ||
| url: https://github.com/Perl/perl5.git | ||
| tag: v5.40.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use 5.42.0 which is the same one that is in the SDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's in the SDK, do we even have to install it as a module? I tried to remove the module but then the installation of exiftool fails:
cp exiftool blib/script/exiftool
"/usr/bin/perl5.42.0" -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/exiftool
Manifying 1 pod document
Manifying 34 pod documents
Manifying 34 pod documents
Manifying 32 pod documents
Manifying 33 pod documents
Manifying 33 pod documents
Manifying 32 pod documents
Manifying 9 pod documents
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
ERROR: Can't create '/usr/bin'
Do not have write permissions on '/usr/bin'
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
at -e line 1.
make: *** [Makefile:1627: pure_site_install] Error 13
Error: module exiftool: Child process exited with code 2
I don't understand why installing Perl as a module avoids that error 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's in the SDK, do we even have to install it as a module?
It did NOT say to not add it, just to use the same version.
It's in the SDK but not in the platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, the Perl module was configured with -Dprefix=$FLATPAK_DEST
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now exiftool won't work. I never said to remove Perl from here. I just said to build 5.42.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in the SDK but not in the platform.
ah, got it. I'll add it again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
bot, build |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: Built for aarch64 and x86_64 architectures. Warnings can be promoted to errors in the future. Please try to resolve them.
|
hfiguiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
115e571 to
6a8b6a2
Compare
|
bot, build |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
❌ Test build failed. Help
|
|
bot, build |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: Built for aarch64 and x86_64 architectures. Warnings can be promoted to errors in the future. Please try to resolve them.
|
So this is a fork? If so you have to use a different icon and name. And what changes was made in the fork? |
Yes
I got the permission of the original author (via email) to use the original icon and name.
The only relevant changes (beside the ones to the Flatpak manifst which resulted from the review of this PR) are:
|
|
So not really a fork. |
|
Depends on your definition of fork I guess. I don't have access to the original git repository, I'm maintaining the forked repo https://gitlab.com/metadatacleaner/metadatacleaner. |
|
What's the status here? Is there a blocker? Can I do anything to move things forward? |
|
I don't see a reason for a new submission with so minimal changes from the original project. |
|
I don't understand. The original project is unmaintained and not available on Flathub anymore. Do you prefer that we add the original, unmaintained project again? Or that it's not available on Flathub at all? |
|
Bottom line is, you can't submit a new app with the same name, icon and no code related changes in your fork as a new one. If that means the app is not available then it's ok. |
Please confirm your submission meets all the criteria