Skip to content

fix(fdc): Fix issue where auth wasn't properly refreshing id token #13509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 17, 2024
Merged

fix(fdc): Fix issue where auth wasn't properly refreshing id token #13509

merged 10 commits into from
Oct 17, 2024

Conversation

maneesht
Copy link
Contributor

@maneesht maneesht commented Oct 16, 2024 •
edited
Loading

  • In ref.dart, added check to see if token needs to be refreshed, which is when:
    • The current token is NOT null AND the lastToken is different from the new token

@maneesht maneesht marked this pull request as ready for review October 16, 2024 23:44
@maneesht maneesht merged commit 0158ad2 into main Oct 17, 2024
25 of 29 checks passed
@maneesht maneesht deleted the mtewani/fix-auth-issue branch October 17, 2024 17:34
@firebase firebase locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

@Lyokone Lyokone Lyokone approved these changes

@russellwheatley russellwheatley Awaiting requested review from russellwheatley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maneesht @cynthiajoan @Lyokone