-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adds additional Crashlytics tools for debugging/analyzing crashes #9020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @raymondlam, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the Crashlytics debugging and analysis capabilities by integrating a suite of new tools. It introduces functionalities to manage notes on crash issues, retrieve top-performing devices, operating systems, and app versions, and update the status of crash issues. These additions aim to provide developers with more comprehensive insights and control over their application's stability directly through the Firebase CLI's MCP tools.
Highlights
- Expanded Crashlytics API Integrations: This PR introduces a comprehensive set of new functions to interact with the Crashlytics API, including
addNote
,deleteNote
,listNotes
,listTopDevices
,listTopOperatingSystems
,listTopVersions
, andupdateIssue
. These functions provide granular control over Crashlytics data. - New MCP Tools for Crashlytics Management: Corresponding to the new API functions, a suite of new
mcp/tools
have been added. These tools (crashlytics_add_note
,crashlytics_delete_note
,crashlytics_list_notes
,crashlytics_list_top_devices
,crashlytics_list_top_operating_systems
,crashlytics_list_top_versions
,crashlytics_update_issue
) enable users to manage and query Crashlytics data directly through command-line or programmatic interfaces. - Enhanced Error Handling and Input Validation: The newly added functions and tools incorporate robust error handling and input validation, particularly for the
appId
parameter, ensuring more reliable and user-friendly interactions with the Crashlytics API. A newAPP_ID_FIELD
constant was introduced for consistent validation. - Refactoring and Simplification of Existing Tools: Existing Crashlytics-related tools like
get_issue_details
andget_sample_crash
have been updated to align with the newAPP_ID_FIELD
constant and streamline their metadata by removing therequiresProject
flag. ThelistTopIssues
function also saw a refactoring to remove theprojectId
parameter, simplifying its usage.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a comprehensive set of new Crashlytics tools for debugging and analyzing crashes. The changes are well-structured, with new API utility functions, corresponding tests, and tool definitions. My review focuses on improving maintainability by reducing code duplication, fixing issues in tests to ensure they are robust and correct, and cleaning up some redundant code in the new tool definitions. Overall, this is a great addition to the MCP toolset.
72657d8
to
367d60b
Compare
…to Crashlytics MCP
Adds the following tools that can be used to debug and fix app crashes.