Secrets set now handles test vs production secrets #8359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annajowang
approved these changes
Mar 25, 2025
| export async function maybeAddSecretToYaml(secretName: string): Promise<void> { | ||
| export async function maybeAddSecretToYaml( | ||
| secretName: string, | ||
| fileName: string = APPHOSTING_BASE_YAML_FILE, |
There was a problem hiding this comment.
nit: update docstring above
Given a secret name, guides the user whether they want to add that secret to the specified apphosting yaml file.
There was a problem hiding this comment.
Fixed other bullets too. Good catch.
src/apphosting/secrets/dialogs.ts
Outdated
Comment on lines
219
to
220
| } else if (upper.startsWith("TEST")) { | ||
| upper = upper.substring("TEST".length); |
There was a problem hiding this comment.
why not stick with "TEST_" only?
Unless there's a common pattern we want to support, "TEST" could always lead to surprises for secrets coincidentally named with a "TEST" prefix (TESTER, TESTING, , and instead we could just say we only support stripping "TEST_".
especially since we're forcing this upon the user as long as they tell us some secret is only for the local emulator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apphosting:secrets:set now asks if the secret is test-only and can update apphosting.emulator.yaml instead for these cases (as well as granting individuals or groups access).
stripe-keyandtest-stripe-keyto both point toSTRIPE_KEYin apphosting.yaml and apphosting.emulator.yaml respectively