Skip to content

fix webframeworks deploy checks #8295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 7, 2025
Merged

fix webframeworks deploy checks #8295

merged 13 commits into from
Mar 7, 2025

Conversation

leoortizz
Copy link
Member

@leoortizz leoortizz commented Mar 6, 2025 •
edited
Loading

Description

Fixes #8274.

Thanks @aalej for nailing down the issue and providing a MCVE.

Scenarios Tested

firebase deploy with and without site in firebase.json
firebase deploy with and without --only
firebase deploy with and without web frameworks

Sample Commands

firebase deploy

@leoortizz leoortizz self-assigned this Mar 6, 2025
@leoortizz leoortizz marked this pull request as ready for review March 6, 2025 20:06
chalosalvador
chalosalvador approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@chalosalvador chalosalvador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @leoortizz and @aalej for working on this 💯

@leoortizz leoortizz enabled auto-merge (squash) March 7, 2025 14:09
@leoortizz leoortizz force-pushed the leoortiz_deployFix branch from 5090422 to 6bdd090 Compare March 7, 2025 14:11
leoortizz
leoortizz commented Mar 7, 2025
View reviewed changes
@leoortizz leoortizz mentioned this pull request Mar 7, 2025
Closed
@leoortizz leoortizz merged commit 34674ac into master Mar 7, 2025
55 checks passed
@leoortizz leoortizz deleted the leoortiz_deployFix branch March 7, 2025 14:31
@aalej aalej mentioned this pull request Mar 13, 2025
Closed
@sarahec sarahec mentioned this pull request Mar 13, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalosalvador chalosalvador chalosalvador approved these changes

@jamesdaniels jamesdaniels Awaiting requested review from jamesdaniels

Assignees

@leoortizz leoortizz

Labels
integration: web frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to deploy to firebase hosting for NextJS application, show 404 (not found) page
2 participants
@leoortizz @chalosalvador