Skip to content

FIRMessagingRemoteNotificationsProxy updated to use GULAppDelegateSwizzler #2683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Apr 4, 2019
Merged

FIRMessagingRemoteNotificationsProxy updated to use GULAppDelegateSwizzler #2683

merged 31 commits into from
Apr 4, 2019

Conversation

maksymmalyhin
Copy link
Contributor

Changes required for #2591

  • GULAppDelegateSwizzler - remote notifications methods support
  • FIRMessagingRemoteNotificationsProxy - swizzling of Application delegate updated to use GULAppDelegateSwizzler

NOTE: FIRMessagingRemoteNotificationsProxy still swizzles UNUserNotificationDelegate methods in its own way. I think, we should refactor it as a separate PR once we finish refactoring of app delegate swizzling in all libraries.

@maksymmalyhin
FIRAuthAppDelegateProxy: implementation updated to use GULAppDelegate…
b2eabf2 
…Swizzler [WIP]
@maksymmalyhin
GULAppDelegateSwizzler - make sure subclass name is unique.
4ab86de
@maksymmalyhin
GoogleUtilities: enable code coverage
1f1560a
@maksymmalyhin
Merge branch 'master'
f4a4638
@maksymmalyhin
GULAppDelegateSwizzler: Add support of remote notification methods
9fcedce
@maksymmalyhin
GULAppDelegateSwizzler - tests for remote notification methods
27c8b5b
@maksymmalyhin
Revert "FIRAuthAppDelegateProxy: implementation updated to use GULApp…
dee28d3 
…DelegateSwizzler [WIP]"

This reverts commit b2eabf2.
@maksymmalyhin
FIRMessaging: prepare to use GULAppDelegateSwizzler [WIP]
5821591
@maksymmalyhin
FIRMessagingRemoteNotificationsProxy - use GULAppDelegateSwizzler [WIP]
908b6ea
@maksymmalyhin
FIRMessagingRemoteNotificationsProxy - AppDelegate proxy - test only …
9e377d2 
…public interface with no assumptions on the implementation details
@maksymmalyhin
FIRMessagingRemoteNotificationsProxy test only public API with no imp…
7861cde 
…lementation details assumptions
@maksymmalyhin
Cleanup
b7703ac
@maksymmalyhin
Cleanup
ad1da54
@maksymmalyhin
Merge branch 'master'
2bdf353
@maksymmalyhin
Merge branch 'mm/messaging-tests'
8eafece
@maksymmalyhin
Merge branch 'master'
e5d2ce8 
Conflicts:
	Example/Messaging/Tests/FIRMessagingRemoteNotificationsProxyTest.m
@maksymmalyhin
Cocoapods 1.6.1: Podfile supports only single post_install hook. It i…
86ff257 
…s applied to all targets. Move the hook to the top level to avoid confusion.