From b6e5f11373cf769322c119067d9183f8a3f69e6f Mon Sep 17 00:00:00 2001
From: Chris Tibbs <eggyeggbean@dhcp-100-76-160-117.sfo.corp.google.com>
Date: Fri, 26 Oct 2018 13:54:04 -0700
Subject: [PATCH 1/7] Rename fine-tuning methods to reflect size class rather
 than orientation

---
 .../Modal/FIDModalViewController.m                 | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/Firebase/InAppMessagingDisplay/Modal/FIDModalViewController.m b/Firebase/InAppMessagingDisplay/Modal/FIDModalViewController.m
index 30427f1a7a8..cf1a6319fe9 100644
--- a/Firebase/InAppMessagingDisplay/Modal/FIDModalViewController.m
+++ b/Firebase/InAppMessagingDisplay/Modal/FIDModalViewController.m
@@ -255,7 +255,7 @@ - (struct TitleBodyButtonHeightInfo)estimateTextBtnColumnHeightWithDisplayWidth:
 // the following two layoutFineTunexx methods make additional adjustments for the view layout
 // in portrait and landscape mode respectively. They are supposed to be triggered from
 // viewDidLayoutSubviews since certain dimension sizes are only available there
-- (void)layoutFineTuneInPortraitMode {
+- (void)layoutFineTuneForCompactHorizontalSizeClass {
   // for tablet case, since we use a fixed card height, the reference would be just the card height
   // for non-tablet case, we want to use a dynamic height , so the reference would be the window
   // height
@@ -339,7 +339,7 @@ - (void)applySmallerSpacingForInLandscapeMode {
   }
 }
 
-- (void)layoutFineTuneInLandscapeMode {
+- (void)layoutFineTuneForRegularHorizontalSizeClass {
   // smaller spacing threshold is applied for screens equal or larger than 4.7 inches
   if (self.view.window.frame.size.height <= 321) {
     [self applySmallerSpacingForInLandscapeMode];
@@ -405,14 +405,14 @@ - (void)layoutFineTuneInLandscapeMode {
 - (void)viewDidLayoutSubviews {
   [super viewDidLayoutSubviews];
 
-  if (self.buttonBottomToContainerBottomInPortraitMode.active) {
+  if (self.traitCollection.horizontalSizeClass == UIUserInterfaceSizeClassCompact) {
     FIRLogDebug(kFIRLoggerInAppMessagingDisplay, @"I-FID300009",
-                @"Modal view rendered in portrait mode");
-    [self layoutFineTuneInPortraitMode];
+                @"Modal view rendered in compact horizontal size class mode");
+    [self layoutFineTuneForCompactHorizontalSizeClass];
   } else {
     FIRLogDebug(kFIRLoggerInAppMessagingDisplay, @"I-FID300010",
-                @"Modal view rendered in landscape mode");
-    [self layoutFineTuneInLandscapeMode];
+                @"Modal view rendered in regular horizontal size class mode");
+    [self layoutFineTuneForRegularHorizontalSizeClass];
   }
 
   // always scroll to the top in case the body area is scrollable

From 679dd1c73d41b1f8df1940523c98026e22b5f91d Mon Sep 17 00:00:00 2001
From: Chris Tibbs <eggyeggbean@dhcp-100-76-160-117.sfo.corp.google.com>
Date: Mon, 29 Oct 2018 14:17:38 -0700
Subject: [PATCH 2/7] Modify existing constraints to de-portrait tablet layout,
 need a card width for tablet now

---
 ...IRInAppMessageDisplayStoryboard.storyboard | 92 ++++++++-----------
 1 file changed, 39 insertions(+), 53 deletions(-)

diff --git a/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard b/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard
index dfe971e6881..9a2495540c7 100644
--- a/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard
+++ b/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard
@@ -1,13 +1,11 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="14113" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES">
-    <device id="retina4_7" orientation="landscape">
+<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="14313.18" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES">
+    <device id="ipad9_7" orientation="landscape">
         <adaptation id="fullscreen"/>
     </device>
     <dependencies>
         <deployment identifier="iOS"/>
-        <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="14088"/>
-        <capability name="Alignment constraints with different attributes" minToolsVersion="5.1"/>
-        <capability name="Constraints to layout margins" minToolsVersion="6.0"/>
+        <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="14283.14"/>
         <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
     </dependencies>
     <scenes>
@@ -20,7 +18,7 @@
                         <viewControllerLayoutGuide type="bottom" id="8Ta-Lb-9Rg"/>
                     </layoutGuides>
                     <view key="view" contentMode="scaleToFill" id="ef6-R8-q1S">
-                        <rect key="frame" x="0.0" y="0.0" width="667" height="375"/>
+                        <rect key="frame" x="0.0" y="0.0" width="1024" height="768"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
                             <imageView userInteractionEnabled="NO" contentMode="scaleToFill" horizontalHuggingPriority="251" verticalHuggingPriority="251" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="rA8-LH-EYm">
@@ -61,11 +59,11 @@
                         <viewControllerLayoutGuide type="bottom" id="K7E-8I-Yw5"/>
                     </layoutGuides>
                     <view key="view" contentMode="scaleToFill" id="vRb-yf-OWE">
-                        <rect key="frame" x="0.0" y="0.0" width="667" height="375"/>
+                        <rect key="frame" x="0.0" y="0.0" width="1024" height="768"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
                             <imageView userInteractionEnabled="NO" contentMode="scaleToFill" horizontalHuggingPriority="251" verticalHuggingPriority="251" translatesAutoresizingMaskIntoConstraints="NO" id="VfB-vw-7up">
-                                <rect key="frame" x="5" y="3" width="60" height="60"/>
+                                <rect key="frame" x="5" y="23" width="60" height="60"/>
                                 <accessibility key="accessibilityConfiguration" identifier="banner-image-view">
                                     <bool key="isElement" value="YES"/>
                                 </accessibility>
@@ -75,14 +73,14 @@
                                 </constraints>
                             </imageView>
                             <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="Messaging Title" textAlignment="natural" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontForContentSizeCategory="YES" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="rzo-9i-rXZ">
-                                <rect key="frame" x="70" y="3" width="577" height="20.5"/>
+                                <rect key="frame" x="70" y="23" width="934" height="20.5"/>
                                 <accessibility key="accessibilityConfiguration" identifier="banner-message-title-view"/>
                                 <fontDescription key="fontDescription" style="UICTFontTextStyleHeadline"/>
                                 <nil key="textColor"/>
                                 <nil key="highlightedColor"/>
                             </label>
                             <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" text="message body" textAlignment="natural" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="GOK-vx-mU8">
-                                <rect key="frame" x="70" y="31" width="577" height="44"/>
+                                <rect key="frame" x="70" y="51.5" width="934" height="216.5"/>
                                 <accessibility key="accessibilityConfiguration" identifier="banner-body-label"/>
                                 <fontDescription key="fontDescription" style="UICTFontTextStyleBody"/>
                                 <nil key="textColor"/>
@@ -131,28 +129,23 @@
                         <viewControllerLayoutGuide type="bottom" id="1nT-S0-O8H"/>
                     </layoutGuides>
                     <view key="view" contentMode="scaleToFill" id="1pz-BP-O6T">
-                        <rect key="frame" x="0.0" y="0.0" width="667" height="375"/>
+                        <rect key="frame" x="0.0" y="0.0" width="1024" height="768"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
-                            <view contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="jER-Re-ODh">
-                                <rect key="frame" x="20" y="52" width="627" height="271"/>
+                            <view contentMode="scaleToFill" ambiguous="YES" translatesAutoresizingMaskIntoConstraints="NO" id="jER-Re-ODh">
+                                <rect key="frame" x="20" y="199.5" width="696" height="369"/>
                                 <subviews>
-                                    <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" verticalCompressionResistancePriority="1000" text="Message Title" textAlignment="center" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontForContentSizeCategory="YES" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="Edi-DJ-cR8">
-                                        <rect key="frame" x="318" y="20" width="285" height="34"/>
+                                    <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" verticalCompressionResistancePriority="1000" ambiguous="YES" text="Message Title" textAlignment="center" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontForContentSizeCategory="YES" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="Edi-DJ-cR8">
+                                        <rect key="frame" x="318" y="20" width="354" height="34"/>
                                         <constraints>
                                             <constraint firstAttribute="height" constant="34" id="Gzz-dd-hYn" userLabel="Title Label Height Constraint"/>
                                         </constraints>
                                         <fontDescription key="fontDescription" style="UICTFontTextStyleTitle2"/>
                                         <nil key="textColor"/>
                                         <nil key="highlightedColor"/>
-                                        <variation key="heightClass=regular-widthClass=compact">
-                                            <mask key="constraints">
-                                                <include reference="Gzz-dd-hYn"/>
-                                            </mask>
-                                        </variation>
                                     </label>
-                                    <imageView userInteractionEnabled="NO" contentMode="scaleToFill" horizontalHuggingPriority="251" verticalHuggingPriority="251" verticalCompressionResistancePriority="700" translatesAutoresizingMaskIntoConstraints="NO" id="c7x-Lf-M58">
-                                        <rect key="frame" x="24" y="20" width="270" height="231"/>
+                                    <imageView userInteractionEnabled="NO" contentMode="scaleToFill" horizontalHuggingPriority="251" verticalHuggingPriority="251" verticalCompressionResistancePriority="700" ambiguous="YES" translatesAutoresizingMaskIntoConstraints="NO" id="c7x-Lf-M58">
+                                        <rect key="frame" x="24" y="69" width="270" height="231"/>
                                         <accessibility key="accessibilityConfiguration" identifier="modal-image-view">
                                             <bool key="isElement" value="YES"/>
                                         </accessibility>
@@ -173,8 +166,8 @@
                                             </mask>
                                         </variation>
                                     </imageView>
-                                    <button opaque="NO" contentMode="scaleToFill" verticalHuggingPriority="252" verticalCompressionResistancePriority="1000" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="roundedRect" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="VmW-ue-K1q">
-                                        <rect key="frame" x="397.5" y="202" width="126" height="36"/>
+                                    <button opaque="NO" contentMode="scaleToFill" verticalHuggingPriority="252" verticalCompressionResistancePriority="1000" ambiguous="YES" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="roundedRect" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="VmW-ue-K1q">
+                                        <rect key="frame" x="432" y="202" width="126" height="36"/>
                                         <accessibility key="accessibilityConfiguration" identifier="message-action-button"/>
                                         <constraints>
                                             <constraint firstAttribute="height" constant="36" id="6T1-on-oWM"/>
@@ -185,8 +178,8 @@
                                             <action selector="actionButtonTapped:" destination="x01-lq-3r6" eventType="touchUpInside" id="EBt-cx-fnZ"/>
                                         </connections>
                                     </button>
-                                    <textView clipsSubviews="YES" clearsContextBeforeDrawing="NO" multipleTouchEnabled="YES" contentMode="scaleToFill" editable="NO" text="Lorem ipsum dolor sit er elit lamet, consectetaur cillium adipisicing pecu, sed do eiusmod tempor " textAlignment="center" translatesAutoresizingMaskIntoConstraints="NO" id="24j-6H-N9j">
-                                        <rect key="frame" x="318" y="78" width="285" height="100"/>
+                                    <textView clipsSubviews="YES" clearsContextBeforeDrawing="NO" multipleTouchEnabled="YES" contentMode="scaleToFill" ambiguous="YES" editable="NO" text="Lorem ipsum dolor sit er elit lamet, consectetaur cillium adipisicing pecu, sed do eiusmod tempor " textAlignment="center" translatesAutoresizingMaskIntoConstraints="NO" id="24j-6H-N9j">
+                                        <rect key="frame" x="318" y="78" width="354" height="100"/>
                                         <accessibility key="accessibilityConfiguration" identifier="message-body-textview"/>
                                         <constraints>
                                             <constraint firstAttribute="height" constant="100" id="h2w-ub-tEc"/>
@@ -223,8 +216,6 @@
                                     <constraint firstAttribute="bottom" secondItem="VmW-ue-K1q" secondAttribute="bottom" constant="24" id="YoE-KS-uWS"/>
                                     <constraint firstItem="c7x-Lf-M58" firstAttribute="leading" secondItem="Edi-DJ-cR8" secondAttribute="leading" id="bD7-OU-bEW"/>
                                     <constraint firstItem="24j-6H-N9j" firstAttribute="leading" secondItem="Edi-DJ-cR8" secondAttribute="leading" id="fWU-5d-D4W"/>
-                                    <constraint firstAttribute="height" relation="lessThanOrEqual" constant="650" id="h4V-1B-MTc"/>
-                                    <constraint firstAttribute="width" constant="400" id="kQ6-xP-grg"/>
                                     <constraint firstItem="c7x-Lf-M58" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="69" id="pyI-1U-ujR">
                                         <variation key="heightClass=compact" constant="20"/>
                                     </constraint>
@@ -238,8 +229,6 @@
                                     <mask key="constraints">
                                         <exclude reference="8Yx-fI-jXG"/>
                                         <exclude reference="MCf-U1-0tP"/>
-                                        <exclude reference="h4V-1B-MTc"/>
-                                        <exclude reference="kQ6-xP-grg"/>
                                         <exclude reference="Hm8-0s-RTs"/>
                                         <exclude reference="JUy-lx-oR6"/>
                                         <exclude reference="Kec-yq-1Pz"/>
@@ -254,7 +243,6 @@
                                         <exclude reference="RbZ-9Q-1S3"/>
                                         <exclude reference="RdS-Ao-GH0"/>
                                         <exclude reference="qgb-13-uT4"/>
-                                        <exclude reference="C8M-PR-rUI"/>
                                         <exclude reference="CSN-TG-E9H"/>
                                         <exclude reference="YoE-KS-uWS"/>
                                         <exclude reference="xXr-od-zOM"/>
@@ -269,45 +257,39 @@
                                         <include reference="7vK-9V-j5H"/>
                                         <include reference="9La-QV-ftg"/>
                                         <include reference="Ait-Na-aVF"/>
-                                        <include reference="0aC-BE-yfJ"/>
-                                        <include reference="fWU-5d-D4W"/>
                                         <include reference="qgb-13-uT4"/>
-                                        <include reference="C8M-PR-rUI"/>
                                         <include reference="xXr-od-zOM"/>
                                     </mask>
                                 </variation>
-                                <variation key="heightClass=regular">
+                                <variation key="widthClass=regular">
                                     <mask key="constraints">
-                                        <include reference="Kec-yq-1Pz"/>
-                                        <include reference="RdS-Ao-GH0"/>
-                                        <include reference="CSN-TG-E9H"/>
+                                        <include reference="MCf-U1-0tP"/>
+                                        <include reference="Hm8-0s-RTs"/>
+                                        <include reference="pyI-1U-ujR"/>
+                                        <include reference="ysk-iC-Hz4"/>
+                                        <include reference="7vK-9V-j5H"/>
+                                        <include reference="9La-QV-ftg"/>
+                                        <include reference="Ait-Na-aVF"/>
+                                        <include reference="qgb-13-uT4"/>
+                                        <include reference="xXr-od-zOM"/>
                                     </mask>
                                 </variation>
                                 <variation key="heightClass=regular-widthClass=compact">
                                     <mask key="constraints">
                                         <include reference="JUy-lx-oR6"/>
+                                        <include reference="Kec-yq-1Pz"/>
                                         <include reference="bD7-OU-bEW"/>
                                         <include reference="FTB-yV-c00"/>
                                         <include reference="JJo-tI-mvn"/>
                                         <include reference="RbZ-9Q-1S3"/>
-                                        <include reference="YoE-KS-uWS"/>
-                                    </mask>
-                                </variation>
-                                <variation key="heightClass=regular-widthClass=regular">
-                                    <mask key="constraints">
-                                        <include reference="h4V-1B-MTc"/>
-                                        <include reference="kQ6-xP-grg"/>
-                                        <include reference="JUy-lx-oR6"/>
-                                        <include reference="bD7-OU-bEW"/>
-                                        <include reference="FTB-yV-c00"/>
-                                        <include reference="JJo-tI-mvn"/>
-                                        <include reference="RbZ-9Q-1S3"/>
+                                        <include reference="RdS-Ao-GH0"/>
+                                        <include reference="CSN-TG-E9H"/>
                                         <include reference="YoE-KS-uWS"/>
                                     </mask>
                                 </variation>
                             </view>
-                            <button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="akA-AE-VPc">
-                                <rect key="frame" x="627" y="32" width="40" height="40"/>
+                            <button opaque="NO" contentMode="scaleToFill" ambiguous="YES" contentHorizontalAlignment="center" contentVerticalAlignment="center" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="akA-AE-VPc">
+                                <rect key="frame" x="696" y="179.5" width="40" height="40"/>
                                 <accessibility key="accessibilityConfiguration" identifier="close-button"/>
                                 <constraints>
                                     <constraint firstAttribute="width" constant="40" id="Dwi-In-x47"/>
@@ -346,6 +328,11 @@
                                 <include reference="kj1-PP-7nG"/>
                             </mask>
                         </variation>
+                        <variation key="widthClass=regular">
+                            <mask key="constraints">
+                                <include reference="Yvr-Y4-aEK"/>
+                            </mask>
+                        </variation>
                         <variation key="heightClass=regular-widthClass=compact">
                             <mask key="constraints">
                                 <include reference="bX2-s2-74w"/>
@@ -375,7 +362,6 @@
                         <outlet property="imageWidthInLandscapeMode" destination="lJJ-PY-Yai" id="gfq-0r-tJ7"/>
                         <outlet property="maxActionButtonHeight" destination="6T1-on-oWM" id="VnS-5x-Y9U"/>
                         <outlet property="maxCardHeightInLandscapeMode" destination="MCf-U1-0tP" id="mcd-hJ-kKU"/>
-                        <outlet property="messageCardHeightMaxInTabletCase" destination="h4V-1B-MTc" id="nOt-9P-n8C"/>
                         <outlet property="messageCardView" destination="jER-Re-ODh" id="Z4R-xH-f6q"/>
                         <outlet property="titleLabel" destination="Edi-DJ-cR8" id="72O-Ya-DCs"/>
                         <outlet property="titleLabelHeightConstraint" destination="Gzz-dd-hYn" id="H2i-6R-dtp"/>

From 941aad3f08a0b8cba7b2b7338508806c9b011e85 Mon Sep 17 00:00:00 2001
From: Chris Tibbs <eggyeggbean@dhcp-100-76-160-117.sfo.corp.google.com>
Date: Tue, 30 Oct 2018 11:42:08 -0700
Subject: [PATCH 3/7] Further constraint tinkering, add identifiers for better
 auto layout debugging

---
 ...IRInAppMessageDisplayStoryboard.storyboard | 137 +++++++++---------
 1 file changed, 69 insertions(+), 68 deletions(-)

diff --git a/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard b/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard
index 9a2495540c7..3dc7b7cb8bd 100644
--- a/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard
+++ b/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="14313.18" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES">
-    <device id="ipad9_7" orientation="landscape">
-        <adaptation id="fullscreen"/>
+    <device id="ipad10_5" orientation="landscape">
+        <adaptation id="splitview2_3"/>
     </device>
     <dependencies>
         <deployment identifier="iOS"/>
@@ -18,7 +18,7 @@
                         <viewControllerLayoutGuide type="bottom" id="8Ta-Lb-9Rg"/>
                     </layoutGuides>
                     <view key="view" contentMode="scaleToFill" id="ef6-R8-q1S">
-                        <rect key="frame" x="0.0" y="0.0" width="1024" height="768"/>
+                        <rect key="frame" x="0.0" y="0.0" width="782" height="834"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
                             <imageView userInteractionEnabled="NO" contentMode="scaleToFill" horizontalHuggingPriority="251" verticalHuggingPriority="251" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="rA8-LH-EYm">
@@ -59,7 +59,7 @@
                         <viewControllerLayoutGuide type="bottom" id="K7E-8I-Yw5"/>
                     </layoutGuides>
                     <view key="view" contentMode="scaleToFill" id="vRb-yf-OWE">
-                        <rect key="frame" x="0.0" y="0.0" width="1024" height="768"/>
+                        <rect key="frame" x="0.0" y="0.0" width="782" height="834"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
                             <imageView userInteractionEnabled="NO" contentMode="scaleToFill" horizontalHuggingPriority="251" verticalHuggingPriority="251" translatesAutoresizingMaskIntoConstraints="NO" id="VfB-vw-7up">
@@ -73,14 +73,14 @@
                                 </constraints>
                             </imageView>
                             <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="Messaging Title" textAlignment="natural" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontForContentSizeCategory="YES" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="rzo-9i-rXZ">
-                                <rect key="frame" x="70" y="23" width="934" height="20.5"/>
+                                <rect key="frame" x="70" y="23" width="692" height="20.5"/>
                                 <accessibility key="accessibilityConfiguration" identifier="banner-message-title-view"/>
                                 <fontDescription key="fontDescription" style="UICTFontTextStyleHeadline"/>
                                 <nil key="textColor"/>
                                 <nil key="highlightedColor"/>
                             </label>
                             <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" text="message body" textAlignment="natural" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="GOK-vx-mU8">
-                                <rect key="frame" x="70" y="51.5" width="934" height="216.5"/>
+                                <rect key="frame" x="70" y="51.5" width="692" height="282.5"/>
                                 <accessibility key="accessibilityConfiguration" identifier="banner-body-label"/>
                                 <fontDescription key="fontDescription" style="UICTFontTextStyleBody"/>
                                 <nil key="textColor"/>
@@ -129,30 +129,30 @@
                         <viewControllerLayoutGuide type="bottom" id="1nT-S0-O8H"/>
                     </layoutGuides>
                     <view key="view" contentMode="scaleToFill" id="1pz-BP-O6T">
-                        <rect key="frame" x="0.0" y="0.0" width="1024" height="768"/>
+                        <rect key="frame" x="0.0" y="0.0" width="782" height="834"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
-                            <view contentMode="scaleToFill" ambiguous="YES" translatesAutoresizingMaskIntoConstraints="NO" id="jER-Re-ODh">
-                                <rect key="frame" x="20" y="199.5" width="696" height="369"/>
+                            <view contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="jER-Re-ODh">
+                                <rect key="frame" x="66" y="232.5" width="650" height="369"/>
                                 <subviews>
-                                    <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" verticalCompressionResistancePriority="1000" ambiguous="YES" text="Message Title" textAlignment="center" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontForContentSizeCategory="YES" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="Edi-DJ-cR8">
-                                        <rect key="frame" x="318" y="20" width="354" height="34"/>
+                                    <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" verticalCompressionResistancePriority="1000" text="Message Title" textAlignment="center" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontForContentSizeCategory="YES" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="Edi-DJ-cR8">
+                                        <rect key="frame" x="318" y="20" width="308" height="34"/>
                                         <constraints>
-                                            <constraint firstAttribute="height" constant="34" id="Gzz-dd-hYn" userLabel="Title Label Height Constraint"/>
+                                            <constraint firstAttribute="height" constant="34" identifier="titleLabelHeight" id="Gzz-dd-hYn" userLabel="Title Label Height Constraint"/>
                                         </constraints>
                                         <fontDescription key="fontDescription" style="UICTFontTextStyleTitle2"/>
                                         <nil key="textColor"/>
                                         <nil key="highlightedColor"/>
                                     </label>
-                                    <imageView userInteractionEnabled="NO" contentMode="scaleToFill" horizontalHuggingPriority="251" verticalHuggingPriority="251" verticalCompressionResistancePriority="700" ambiguous="YES" translatesAutoresizingMaskIntoConstraints="NO" id="c7x-Lf-M58">
+                                    <imageView userInteractionEnabled="NO" contentMode="scaleToFill" horizontalHuggingPriority="251" verticalHuggingPriority="251" verticalCompressionResistancePriority="700" translatesAutoresizingMaskIntoConstraints="NO" id="c7x-Lf-M58">
                                         <rect key="frame" x="24" y="69" width="270" height="231"/>
                                         <accessibility key="accessibilityConfiguration" identifier="modal-image-view">
                                             <bool key="isElement" value="YES"/>
                                         </accessibility>
                                         <constraints>
-                                            <constraint firstAttribute="height" constant="144" id="EeQ-n5-WE7" userLabel="actual height at runtime"/>
-                                            <constraint firstAttribute="width" constant="270" id="lJJ-PY-Yai"/>
-                                            <constraint firstAttribute="height" priority="900" constant="230.66999999999999" placeholder="YES" id="pm4-tp-Fjt" userLabel="height to make interface builder happy"/>
+                                            <constraint firstAttribute="height" constant="144" identifier="imageViewRunTimeHeight" id="EeQ-n5-WE7" userLabel="actual height at runtime"/>
+                                            <constraint firstAttribute="width" constant="270" identifier="imageWidthForRegularWidth" id="lJJ-PY-Yai"/>
+                                            <constraint firstAttribute="height" priority="900" constant="230.66999999999999" placeholder="YES" identifier="heightToMakeInterfaceBuilderHappy" id="pm4-tp-Fjt" userLabel="height to make interface builder happy"/>
                                         </constraints>
                                         <variation key="default">
                                             <mask key="constraints">
@@ -165,12 +165,17 @@
                                                 <include reference="lJJ-PY-Yai"/>
                                             </mask>
                                         </variation>
+                                        <variation key="widthClass=regular">
+                                            <mask key="constraints">
+                                                <include reference="lJJ-PY-Yai"/>
+                                            </mask>
+                                        </variation>
                                     </imageView>
-                                    <button opaque="NO" contentMode="scaleToFill" verticalHuggingPriority="252" verticalCompressionResistancePriority="1000" ambiguous="YES" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="roundedRect" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="VmW-ue-K1q">
-                                        <rect key="frame" x="432" y="202" width="126" height="36"/>
+                                    <button opaque="NO" contentMode="scaleToFill" verticalHuggingPriority="252" verticalCompressionResistancePriority="1000" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="roundedRect" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="VmW-ue-K1q">
+                                        <rect key="frame" x="409" y="202" width="126" height="36"/>
                                         <accessibility key="accessibilityConfiguration" identifier="message-action-button"/>
                                         <constraints>
-                                            <constraint firstAttribute="height" constant="36" id="6T1-on-oWM"/>
+                                            <constraint firstAttribute="height" constant="36" identifier="maxActionButtonHeight" id="6T1-on-oWM"/>
                                         </constraints>
                                         <inset key="contentEdgeInsets" minX="16" minY="9" maxX="16" maxY="9"/>
                                         <state key="normal" title="Action Button"/>
@@ -178,11 +183,11 @@
                                             <action selector="actionButtonTapped:" destination="x01-lq-3r6" eventType="touchUpInside" id="EBt-cx-fnZ"/>
                                         </connections>
                                     </button>
-                                    <textView clipsSubviews="YES" clearsContextBeforeDrawing="NO" multipleTouchEnabled="YES" contentMode="scaleToFill" ambiguous="YES" editable="NO" text="Lorem ipsum dolor sit er elit lamet, consectetaur cillium adipisicing pecu, sed do eiusmod tempor " textAlignment="center" translatesAutoresizingMaskIntoConstraints="NO" id="24j-6H-N9j">
-                                        <rect key="frame" x="318" y="78" width="354" height="100"/>
+                                    <textView clipsSubviews="YES" clearsContextBeforeDrawing="NO" multipleTouchEnabled="YES" contentMode="scaleToFill" editable="NO" text="Lorem ipsum dolor sit er elit lamet, consectetaur cillium adipisicing pecu, sed do eiusmod tempor " textAlignment="center" translatesAutoresizingMaskIntoConstraints="NO" id="24j-6H-N9j">
+                                        <rect key="frame" x="318" y="78" width="308" height="100"/>
                                         <accessibility key="accessibilityConfiguration" identifier="message-body-textview"/>
                                         <constraints>
-                                            <constraint firstAttribute="height" constant="100" id="h2w-ub-tEc"/>
+                                            <constraint firstAttribute="height" constant="100" identifier="bodyTextViewHeight" id="h2w-ub-tEc"/>
                                         </constraints>
                                         <fontDescription key="fontDescription" style="UICTFontTextStyleBody"/>
                                         <textInputTraits key="textInputTraits" autocapitalizationType="sentences"/>
@@ -193,41 +198,37 @@
                                     <bool key="isElement" value="NO"/>
                                 </accessibility>
                                 <constraints>
-                                    <constraint firstItem="24j-6H-N9j" firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" id="0aC-BE-yfJ"/>
-                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="leading" secondItem="c7x-Lf-M58" secondAttribute="trailing" constant="-314" id="7vK-9V-j5H">
-                                        <variation key="heightClass=compact" constant="24"/>
-                                    </constraint>
-                                    <constraint firstAttribute="height" priority="100" constant="650" id="8Yx-fI-jXG"/>
-                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="20" id="9La-QV-ftg"/>
-                                    <constraint firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" constant="163.33333333333337" id="Ait-Na-aVF">
-                                        <variation key="heightClass=compact" constant="24"/>
-                                    </constraint>
-                                    <constraint firstItem="VmW-ue-K1q" firstAttribute="centerX" secondItem="Edi-DJ-cR8" secondAttribute="centerX" id="C8M-PR-rUI"/>
-                                    <constraint firstItem="VmW-ue-K1q" firstAttribute="centerX" secondItem="jER-Re-ODh" secondAttribute="centerX" id="CSN-TG-E9H"/>
-                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="24" id="FTB-yV-c00"/>
-                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="centerY" secondItem="jER-Re-ODh" secondAttribute="centerY" id="Hm8-0s-RTs"/>
-                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="leading" secondItem="jER-Re-ODh" secondAttribute="leading" constant="24" id="JJo-tI-mvn"/>
-                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" id="JUy-lx-oR6"/>
-                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="top" secondItem="Edi-DJ-cR8" secondAttribute="bottom" constant="24" id="Kec-yq-1Pz"/>
-                                    <constraint firstAttribute="height" relation="lessThanOrEqual" constant="1000" id="MCf-U1-0tP"/>
-                                    <constraint firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" constant="24" id="RbZ-9Q-1S3"/>
-                                    <constraint firstItem="24j-6H-N9j" firstAttribute="top" secondItem="c7x-Lf-M58" secondAttribute="bottom" constant="24" id="RdS-Ao-GH0"/>
-                                    <constraint firstItem="VmW-ue-K1q" firstAttribute="top" secondItem="24j-6H-N9j" secondAttribute="bottom" constant="24" id="Vej-p0-b6w"/>
-                                    <constraint firstAttribute="bottom" secondItem="VmW-ue-K1q" secondAttribute="bottom" constant="24" id="YoE-KS-uWS"/>
-                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="leading" secondItem="Edi-DJ-cR8" secondAttribute="leading" id="bD7-OU-bEW"/>
-                                    <constraint firstItem="24j-6H-N9j" firstAttribute="leading" secondItem="Edi-DJ-cR8" secondAttribute="leading" id="fWU-5d-D4W"/>
-                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="69" id="pyI-1U-ujR">
-                                        <variation key="heightClass=compact" constant="20"/>
-                                    </constraint>
-                                    <constraint firstItem="24j-6H-N9j" firstAttribute="top" secondItem="Edi-DJ-cR8" secondAttribute="bottom" constant="24" id="qgb-13-uT4"/>
-                                    <constraint firstAttribute="bottom" relation="greaterThanOrEqual" secondItem="VmW-ue-K1q" secondAttribute="bottom" priority="900" constant="20" id="xXr-od-zOM">
+                                    <constraint firstItem="24j-6H-N9j" firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" identifier="titleLabelMaxX == bodyTextViewMaxX" id="0aC-BE-yfJ"/>
+                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="leading" secondItem="c7x-Lf-M58" secondAttribute="trailing" constant="24" identifier="titleLabelSpacingAfterImageViewForRegularWidth" id="7vK-9V-j5H"/>
+                                    <constraint firstAttribute="height" priority="100" constant="650" identifier="fixedMessageCardHeight" id="8Yx-fI-jXG"/>
+                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="20" identifier="titleLabelTopPaddingForRegularWidth" id="9La-QV-ftg" userLabel="Title Top To Card View Top (?)"/>
+                                    <constraint firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" constant="24" identifier="titleLabelRightPaddingForRegularWidth" id="Ait-Na-aVF"/>
+                                    <constraint firstItem="VmW-ue-K1q" firstAttribute="centerX" secondItem="Edi-DJ-cR8" secondAttribute="centerX" identifier="actionButtonCenterX == titleLabelCenterX" id="C8M-PR-rUI"/>
+                                    <constraint firstItem="VmW-ue-K1q" firstAttribute="centerX" secondItem="jER-Re-ODh" secondAttribute="centerX" identifier="actionButtonCenteredInCardForCompactWidth" id="CSN-TG-E9H"/>
+                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="24" identifier="titleLabelTopPaddingForCompactWidth" id="FTB-yV-c00"/>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="centerY" secondItem="jER-Re-ODh" secondAttribute="centerY" identifier="imageViewCenteredVerticallyInCardView" id="Hm8-0s-RTs"/>
+                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="leading" secondItem="jER-Re-ODh" secondAttribute="leading" constant="24" identifier="titleLabelLeftPaddingForCompactWidth" id="JJo-tI-mvn"/>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" identifier="imageViewMaxX == titleLabelMaxX" id="JUy-lx-oR6"/>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="top" secondItem="Edi-DJ-cR8" secondAttribute="bottom" constant="24" identifier="imageViewSpacingBelowTitle" id="Kec-yq-1Pz"/>
+                                    <constraint firstAttribute="width" constant="650" identifier="cardWidthForTablet" id="Ln4-8U-D7V" userLabel="Card Width for Tablet"/>
+                                    <constraint firstAttribute="height" relation="lessThanOrEqual" constant="1000" identifier="maxCardViewHeightForRegularWidth" id="MCf-U1-0tP"/>
+                                    <constraint firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" constant="24" identifier="titleLabelRightPaddingForCompactWidth" id="RbZ-9Q-1S3"/>
+                                    <constraint firstItem="24j-6H-N9j" firstAttribute="top" secondItem="c7x-Lf-M58" secondAttribute="bottom" constant="24" identifier="bodyTextViewSpacingBelowImageViewForCompactWidth" id="RdS-Ao-GH0"/>
+                                    <constraint firstItem="VmW-ue-K1q" firstAttribute="top" secondItem="24j-6H-N9j" secondAttribute="bottom" constant="24" identifier="actionButtonSpacingBelowBodyTextView" id="Vej-p0-b6w"/>
+                                    <constraint firstAttribute="bottom" secondItem="VmW-ue-K1q" secondAttribute="bottom" constant="24" identifier="actionButtonBottomPaddingForCompactWidth" id="YoE-KS-uWS"/>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="leading" secondItem="Edi-DJ-cR8" secondAttribute="leading" identifier="imageViewMinX == titleLabelMinX" id="bD7-OU-bEW"/>
+                                    <constraint firstItem="24j-6H-N9j" firstAttribute="leading" secondItem="Edi-DJ-cR8" secondAttribute="leading" identifier="bodyTextViewMinX == titleLabelMinX" id="fWU-5d-D4W"/>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="69" identifier="imageViewVerticalTopPadding" id="pyI-1U-ujR" userLabel="Image Top To Card Top In Landscape Mode (?)">
                                         <variation key="heightClass=compact" constant="20"/>
                                     </constraint>
-                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="leading" secondItem="jER-Re-ODh" secondAttribute="leading" constant="24" id="ysk-iC-Hz4"/>
+                                    <constraint firstItem="24j-6H-N9j" firstAttribute="top" secondItem="Edi-DJ-cR8" secondAttribute="bottom" constant="24" identifier="bodyTextViewBelowTitleLabelForRegularWidth" id="qgb-13-uT4"/>
+                                    <constraint firstAttribute="bottom" relation="greaterThanOrEqual" secondItem="VmW-ue-K1q" secondAttribute="bottom" priority="900" constant="20" identifier="actionButtonBottomPaddingForRegularWidth" id="xXr-od-zOM"/>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="leading" secondItem="jER-Re-ODh" secondAttribute="leading" constant="24" identifier="imageViewLeftPaddingForRegularWidth" id="ysk-iC-Hz4"/>
                                 </constraints>
                                 <variation key="default">
                                     <mask key="constraints">
                                         <exclude reference="8Yx-fI-jXG"/>
+                                        <exclude reference="Ln4-8U-D7V"/>
                                         <exclude reference="MCf-U1-0tP"/>
                                         <exclude reference="Hm8-0s-RTs"/>
                                         <exclude reference="JUy-lx-oR6"/>
@@ -287,13 +288,18 @@
                                         <include reference="YoE-KS-uWS"/>
                                     </mask>
                                 </variation>
+                                <variation key="heightClass=regular-widthClass=regular">
+                                    <mask key="constraints">
+                                        <include reference="Ln4-8U-D7V"/>
+                                    </mask>
+                                </variation>
                             </view>
-                            <button opaque="NO" contentMode="scaleToFill" ambiguous="YES" contentHorizontalAlignment="center" contentVerticalAlignment="center" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="akA-AE-VPc">
-                                <rect key="frame" x="696" y="179.5" width="40" height="40"/>
+                            <button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="akA-AE-VPc">
+                                <rect key="frame" x="696" y="212.5" width="40" height="40"/>
                                 <accessibility key="accessibilityConfiguration" identifier="close-button"/>
                                 <constraints>
-                                    <constraint firstAttribute="width" constant="40" id="Dwi-In-x47"/>
-                                    <constraint firstAttribute="height" constant="40" id="tIe-pH-jRO"/>
+                                    <constraint firstAttribute="width" constant="40" identifier="closeButtonWidth" id="Dwi-In-x47"/>
+                                    <constraint firstAttribute="height" constant="40" identifier="closeButtonHeight" id="tIe-pH-jRO"/>
                                 </constraints>
                                 <state key="normal" backgroundImage="close-with-transparency.png"/>
                                 <connections>
@@ -303,16 +309,16 @@
                         </subviews>
                         <color key="backgroundColor" white="1" alpha="1" colorSpace="calibratedWhite"/>
                         <constraints>
-                            <constraint firstItem="jER-Re-ODh" firstAttribute="centerY" secondItem="1pz-BP-O6T" secondAttribute="centerY" id="GSo-F2-pSS"/>
-                            <constraint firstItem="jER-Re-ODh" firstAttribute="top" relation="greaterThanOrEqual" secondItem="42w-41-Nyy" secondAttribute="bottom" constant="116.66666666666663" id="Yvr-Y4-aEK">
+                            <constraint firstItem="jER-Re-ODh" firstAttribute="centerY" secondItem="1pz-BP-O6T" secondAttribute="centerY" identifier="cardViewVerticallyCenteredInSuperview" id="GSo-F2-pSS"/>
+                            <constraint firstItem="jER-Re-ODh" firstAttribute="top" relation="greaterThanOrEqual" secondItem="42w-41-Nyy" secondAttribute="bottom" constant="116.66666666666663" identifier="cardViewMinTopPaddingInSuperviewForRegularWidth" id="Yvr-Y4-aEK">
                                 <variation key="heightClass=compact" constant="24"/>
                             </constraint>
-                            <constraint firstItem="jER-Re-ODh" firstAttribute="leading" secondItem="1pz-BP-O6T" secondAttribute="leadingMargin" constant="10" id="bX2-s2-74w"/>
-                            <constraint firstItem="jER-Re-ODh" firstAttribute="top" relation="greaterThanOrEqual" secondItem="42w-41-Nyy" secondAttribute="bottom" constant="10" id="fyU-hx-Wh1"/>
-                            <constraint firstItem="jER-Re-ODh" firstAttribute="leading" secondItem="1pz-BP-O6T" secondAttribute="leading" constant="20" id="kj1-PP-7nG"/>
-                            <constraint firstItem="jER-Re-ODh" firstAttribute="centerX" secondItem="1pz-BP-O6T" secondAttribute="centerX" id="m0a-I2-6sC"/>
-                            <constraint firstItem="akA-AE-VPc" firstAttribute="centerX" secondItem="jER-Re-ODh" secondAttribute="trailing" id="nIB-zo-TIv"/>
-                            <constraint firstItem="akA-AE-VPc" firstAttribute="centerY" secondItem="jER-Re-ODh" secondAttribute="top" id="va9-kv-0KG"/>
+                            <constraint firstItem="jER-Re-ODh" firstAttribute="leading" secondItem="1pz-BP-O6T" secondAttribute="leadingMargin" constant="10" identifier="cardViewLeftSpacingInLandscapePhone" id="bX2-s2-74w"/>
+                            <constraint firstItem="jER-Re-ODh" firstAttribute="top" relation="greaterThanOrEqual" secondItem="42w-41-Nyy" secondAttribute="bottom" constant="10" identifier="cardViewMinTopPaddingInSuperviewForPortraitPhone" id="fyU-hx-Wh1"/>
+                            <constraint firstItem="jER-Re-ODh" firstAttribute="leading" secondItem="1pz-BP-O6T" secondAttribute="leading" constant="20" identifier="cardViewLeftPaddingForLandscapePhone" id="kj1-PP-7nG"/>
+                            <constraint firstItem="jER-Re-ODh" firstAttribute="centerX" secondItem="1pz-BP-O6T" secondAttribute="centerX" identifier="cardViewHorizontallyCenteredInSuperview" id="m0a-I2-6sC"/>
+                            <constraint firstItem="akA-AE-VPc" firstAttribute="centerX" secondItem="jER-Re-ODh" secondAttribute="trailing" identifier="closeButtonMaxX == cardViewMaxX" id="nIB-zo-TIv"/>
+                            <constraint firstItem="akA-AE-VPc" firstAttribute="centerY" secondItem="jER-Re-ODh" secondAttribute="top" identifier="closeButtonMinY == cardViewMinY" id="va9-kv-0KG"/>
                         </constraints>
                         <variation key="default">
                             <mask key="constraints">
@@ -339,11 +345,6 @@
                                 <include reference="fyU-hx-Wh1"/>
                             </mask>
                         </variation>
-                        <variation key="heightClass=regular-widthClass=regular">
-                            <mask key="constraints">
-                                <include reference="fyU-hx-Wh1"/>
-                            </mask>
-                        </variation>
                     </view>
                     <connections>
                         <outlet property="actionButton" destination="VmW-ue-K1q" id="eAv-DD-aQX"/>

From fbfeb6a436235f124623b5c236ad667e497095f9 Mon Sep 17 00:00:00 2001
From: Chris Tibbs <eggyeggbean@dhcp-100-76-160-117.sfo.corp.google.com>
Date: Wed, 31 Oct 2018 10:43:22 -0700
Subject: [PATCH 4/7] More constraints for "landscape" appearance in tablet.
 Looks good for every case except Thin Image, which blows up the height of the
 message card

---
 ...IRInAppMessageDisplayStoryboard.storyboard | 41 ++++++++-----------
 1 file changed, 18 insertions(+), 23 deletions(-)

diff --git a/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard b/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard
index 3dc7b7cb8bd..c7890e6478e 100644
--- a/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard
+++ b/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="14313.18" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES">
-    <device id="ipad10_5" orientation="landscape">
-        <adaptation id="splitview2_3"/>
+    <device id="ipad9_7" orientation="portrait">
+        <adaptation id="fullscreen"/>
     </device>
     <dependencies>
         <deployment identifier="iOS"/>
@@ -18,7 +18,7 @@
                         <viewControllerLayoutGuide type="bottom" id="8Ta-Lb-9Rg"/>
                     </layoutGuides>
                     <view key="view" contentMode="scaleToFill" id="ef6-R8-q1S">
-                        <rect key="frame" x="0.0" y="0.0" width="782" height="834"/>
+                        <rect key="frame" x="0.0" y="0.0" width="768" height="1024"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
                             <imageView userInteractionEnabled="NO" contentMode="scaleToFill" horizontalHuggingPriority="251" verticalHuggingPriority="251" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="rA8-LH-EYm">
@@ -59,7 +59,7 @@
                         <viewControllerLayoutGuide type="bottom" id="K7E-8I-Yw5"/>
                     </layoutGuides>
                     <view key="view" contentMode="scaleToFill" id="vRb-yf-OWE">
-                        <rect key="frame" x="0.0" y="0.0" width="782" height="834"/>
+                        <rect key="frame" x="0.0" y="0.0" width="768" height="1024"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
                             <imageView userInteractionEnabled="NO" contentMode="scaleToFill" horizontalHuggingPriority="251" verticalHuggingPriority="251" translatesAutoresizingMaskIntoConstraints="NO" id="VfB-vw-7up">
@@ -73,14 +73,14 @@
                                 </constraints>
                             </imageView>
                             <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="Messaging Title" textAlignment="natural" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontForContentSizeCategory="YES" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="rzo-9i-rXZ">
-                                <rect key="frame" x="70" y="23" width="692" height="20.5"/>
+                                <rect key="frame" x="70" y="23" width="678" height="20.5"/>
                                 <accessibility key="accessibilityConfiguration" identifier="banner-message-title-view"/>
                                 <fontDescription key="fontDescription" style="UICTFontTextStyleHeadline"/>
                                 <nil key="textColor"/>
                                 <nil key="highlightedColor"/>
                             </label>
                             <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" text="message body" textAlignment="natural" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="GOK-vx-mU8">
-                                <rect key="frame" x="70" y="51.5" width="692" height="282.5"/>
+                                <rect key="frame" x="70" y="51.5" width="678" height="472.5"/>
                                 <accessibility key="accessibilityConfiguration" identifier="banner-body-label"/>
                                 <fontDescription key="fontDescription" style="UICTFontTextStyleBody"/>
                                 <nil key="textColor"/>
@@ -129,11 +129,11 @@
                         <viewControllerLayoutGuide type="bottom" id="1nT-S0-O8H"/>
                     </layoutGuides>
                     <view key="view" contentMode="scaleToFill" id="1pz-BP-O6T">
-                        <rect key="frame" x="0.0" y="0.0" width="782" height="834"/>
+                        <rect key="frame" x="0.0" y="0.0" width="768" height="1024"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
                             <view contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="jER-Re-ODh">
-                                <rect key="frame" x="66" y="232.5" width="650" height="369"/>
+                                <rect key="frame" x="59" y="372.5" width="650" height="279"/>
                                 <subviews>
                                     <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" verticalCompressionResistancePriority="1000" text="Message Title" textAlignment="center" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontForContentSizeCategory="YES" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="Edi-DJ-cR8">
                                         <rect key="frame" x="318" y="20" width="308" height="34"/>
@@ -145,14 +145,14 @@
                                         <nil key="highlightedColor"/>
                                     </label>
                                     <imageView userInteractionEnabled="NO" contentMode="scaleToFill" horizontalHuggingPriority="251" verticalHuggingPriority="251" verticalCompressionResistancePriority="700" translatesAutoresizingMaskIntoConstraints="NO" id="c7x-Lf-M58">
-                                        <rect key="frame" x="24" y="69" width="270" height="231"/>
+                                        <rect key="frame" x="24" y="24" width="270" height="231"/>
                                         <accessibility key="accessibilityConfiguration" identifier="modal-image-view">
                                             <bool key="isElement" value="YES"/>
                                         </accessibility>
                                         <constraints>
                                             <constraint firstAttribute="height" constant="144" identifier="imageViewRunTimeHeight" id="EeQ-n5-WE7" userLabel="actual height at runtime"/>
                                             <constraint firstAttribute="width" constant="270" identifier="imageWidthForRegularWidth" id="lJJ-PY-Yai"/>
-                                            <constraint firstAttribute="height" priority="900" constant="230.66999999999999" placeholder="YES" identifier="heightToMakeInterfaceBuilderHappy" id="pm4-tp-Fjt" userLabel="height to make interface builder happy"/>
+                                            <constraint firstAttribute="height" priority="900" constant="230.66999999999999" placeholder="YES" identifier="heightToMakeInterfaceBuilderHappy" id="pm4-tp-Fjt" userLabel="image height to make interface builder happy"/>
                                         </constraints>
                                         <variation key="default">
                                             <mask key="constraints">
@@ -198,9 +198,11 @@
                                     <bool key="isElement" value="NO"/>
                                 </accessibility>
                                 <constraints>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="top" relation="greaterThanOrEqual" secondItem="jER-Re-ODh" secondAttribute="top" constant="24" id="0Fp-k2-48a"/>
                                     <constraint firstItem="24j-6H-N9j" firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" identifier="titleLabelMaxX == bodyTextViewMaxX" id="0aC-BE-yfJ"/>
                                     <constraint firstItem="Edi-DJ-cR8" firstAttribute="leading" secondItem="c7x-Lf-M58" secondAttribute="trailing" constant="24" identifier="titleLabelSpacingAfterImageViewForRegularWidth" id="7vK-9V-j5H"/>
                                     <constraint firstAttribute="height" priority="100" constant="650" identifier="fixedMessageCardHeight" id="8Yx-fI-jXG"/>
+                                    <constraint firstAttribute="height" constant="279" placeholder="YES" id="8qu-C8-A9u" userLabel="card height to make interface builder happy"/>
                                     <constraint firstItem="Edi-DJ-cR8" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="20" identifier="titleLabelTopPaddingForRegularWidth" id="9La-QV-ftg" userLabel="Title Top To Card View Top (?)"/>
                                     <constraint firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" constant="24" identifier="titleLabelRightPaddingForRegularWidth" id="Ait-Na-aVF"/>
                                     <constraint firstItem="VmW-ue-K1q" firstAttribute="centerX" secondItem="Edi-DJ-cR8" secondAttribute="centerX" identifier="actionButtonCenterX == titleLabelCenterX" id="C8M-PR-rUI"/>
@@ -218,9 +220,8 @@
                                     <constraint firstAttribute="bottom" secondItem="VmW-ue-K1q" secondAttribute="bottom" constant="24" identifier="actionButtonBottomPaddingForCompactWidth" id="YoE-KS-uWS"/>
                                     <constraint firstItem="c7x-Lf-M58" firstAttribute="leading" secondItem="Edi-DJ-cR8" secondAttribute="leading" identifier="imageViewMinX == titleLabelMinX" id="bD7-OU-bEW"/>
                                     <constraint firstItem="24j-6H-N9j" firstAttribute="leading" secondItem="Edi-DJ-cR8" secondAttribute="leading" identifier="bodyTextViewMinX == titleLabelMinX" id="fWU-5d-D4W"/>
-                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="69" identifier="imageViewVerticalTopPadding" id="pyI-1U-ujR" userLabel="Image Top To Card Top In Landscape Mode (?)">
-                                        <variation key="heightClass=compact" constant="20"/>
-                                    </constraint>
+                                    <constraint firstAttribute="bottom" relation="greaterThanOrEqual" secondItem="c7x-Lf-M58" secondAttribute="bottom" constant="24" id="ivB-jb-LVl"/>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="20" identifier="imageViewVerticalTopPadding" id="pyI-1U-ujR" userLabel="Image Top To Card Top In Landscape Mode (?)"/>
                                     <constraint firstItem="24j-6H-N9j" firstAttribute="top" secondItem="Edi-DJ-cR8" secondAttribute="bottom" constant="24" identifier="bodyTextViewBelowTitleLabelForRegularWidth" id="qgb-13-uT4"/>
                                     <constraint firstAttribute="bottom" relation="greaterThanOrEqual" secondItem="VmW-ue-K1q" secondAttribute="bottom" priority="900" constant="20" identifier="actionButtonBottomPaddingForRegularWidth" id="xXr-od-zOM"/>
                                     <constraint firstItem="c7x-Lf-M58" firstAttribute="leading" secondItem="jER-Re-ODh" secondAttribute="leading" constant="24" identifier="imageViewLeftPaddingForRegularWidth" id="ysk-iC-Hz4"/>
@@ -228,6 +229,7 @@
                                 <variation key="default">
                                     <mask key="constraints">
                                         <exclude reference="8Yx-fI-jXG"/>
+                                        <exclude reference="8qu-C8-A9u"/>
                                         <exclude reference="Ln4-8U-D7V"/>
                                         <exclude reference="MCf-U1-0tP"/>
                                         <exclude reference="Hm8-0s-RTs"/>
@@ -266,7 +268,6 @@
                                     <mask key="constraints">
                                         <include reference="MCf-U1-0tP"/>
                                         <include reference="Hm8-0s-RTs"/>
-                                        <include reference="pyI-1U-ujR"/>
                                         <include reference="ysk-iC-Hz4"/>
                                         <include reference="7vK-9V-j5H"/>
                                         <include reference="9La-QV-ftg"/>
@@ -290,12 +291,13 @@
                                 </variation>
                                 <variation key="heightClass=regular-widthClass=regular">
                                     <mask key="constraints">
+                                        <include reference="8qu-C8-A9u"/>
                                         <include reference="Ln4-8U-D7V"/>
                                     </mask>
                                 </variation>
                             </view>
                             <button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="akA-AE-VPc">
-                                <rect key="frame" x="696" y="212.5" width="40" height="40"/>
+                                <rect key="frame" x="689" y="352.5" width="40" height="40"/>
                                 <accessibility key="accessibilityConfiguration" identifier="close-button"/>
                                 <constraints>
                                     <constraint firstAttribute="width" constant="40" identifier="closeButtonWidth" id="Dwi-In-x47"/>
@@ -310,9 +312,7 @@
                         <color key="backgroundColor" white="1" alpha="1" colorSpace="calibratedWhite"/>
                         <constraints>
                             <constraint firstItem="jER-Re-ODh" firstAttribute="centerY" secondItem="1pz-BP-O6T" secondAttribute="centerY" identifier="cardViewVerticallyCenteredInSuperview" id="GSo-F2-pSS"/>
-                            <constraint firstItem="jER-Re-ODh" firstAttribute="top" relation="greaterThanOrEqual" secondItem="42w-41-Nyy" secondAttribute="bottom" constant="116.66666666666663" identifier="cardViewMinTopPaddingInSuperviewForRegularWidth" id="Yvr-Y4-aEK">
-                                <variation key="heightClass=compact" constant="24"/>
-                            </constraint>
+                            <constraint firstItem="jER-Re-ODh" firstAttribute="top" relation="greaterThanOrEqual" secondItem="42w-41-Nyy" secondAttribute="bottom" constant="24" identifier="cardViewMinTopPaddingInSuperviewForRegularWidth" id="Yvr-Y4-aEK"/>
                             <constraint firstItem="jER-Re-ODh" firstAttribute="leading" secondItem="1pz-BP-O6T" secondAttribute="leadingMargin" constant="10" identifier="cardViewLeftSpacingInLandscapePhone" id="bX2-s2-74w"/>
                             <constraint firstItem="jER-Re-ODh" firstAttribute="top" relation="greaterThanOrEqual" secondItem="42w-41-Nyy" secondAttribute="bottom" constant="10" identifier="cardViewMinTopPaddingInSuperviewForPortraitPhone" id="fyU-hx-Wh1"/>
                             <constraint firstItem="jER-Re-ODh" firstAttribute="leading" secondItem="1pz-BP-O6T" secondAttribute="leading" constant="20" identifier="cardViewLeftPaddingForLandscapePhone" id="kj1-PP-7nG"/>
@@ -334,11 +334,6 @@
                                 <include reference="kj1-PP-7nG"/>
                             </mask>
                         </variation>
-                        <variation key="widthClass=regular">
-                            <mask key="constraints">
-                                <include reference="Yvr-Y4-aEK"/>
-                            </mask>
-                        </variation>
                         <variation key="heightClass=regular-widthClass=compact">
                             <mask key="constraints">
                                 <include reference="bX2-s2-74w"/>

From b21a3a9f1c0228aff7dc13bd14ab2949aa9242b8 Mon Sep 17 00:00:00 2001
From: Chris Tibbs <eggyeggbean@dhcp-100-76-160-117.sfo.corp.google.com>
Date: Wed, 31 Oct 2018 15:16:31 -0700
Subject: [PATCH 5/7] Fix fine tune layout methods to correctly fine tune for
 compact height and width

---
 .../Modal/FIDModalViewController.m            | 19 ++++++-----
 ...IRInAppMessageDisplayStoryboard.storyboard | 34 +++++++++++--------
 2 files changed, 29 insertions(+), 24 deletions(-)

diff --git a/Firebase/InAppMessagingDisplay/Modal/FIDModalViewController.m b/Firebase/InAppMessagingDisplay/Modal/FIDModalViewController.m
index cf1a6319fe9..292600f3264 100644
--- a/Firebase/InAppMessagingDisplay/Modal/FIDModalViewController.m
+++ b/Firebase/InAppMessagingDisplay/Modal/FIDModalViewController.m
@@ -255,7 +255,7 @@ - (struct TitleBodyButtonHeightInfo)estimateTextBtnColumnHeightWithDisplayWidth:
 // the following two layoutFineTunexx methods make additional adjustments for the view layout
 // in portrait and landscape mode respectively. They are supposed to be triggered from
 // viewDidLayoutSubviews since certain dimension sizes are only available there
-- (void)layoutFineTuneForCompactHorizontalSizeClass {
+- (void)layoutFineTuneForPortraitMode {
   // for tablet case, since we use a fixed card height, the reference would be just the card height
   // for non-tablet case, we want to use a dynamic height , so the reference would be the window
   // height
@@ -339,7 +339,7 @@ - (void)applySmallerSpacingForInLandscapeMode {
   }
 }
 
-- (void)layoutFineTuneForRegularHorizontalSizeClass {
+- (void)layoutFineTuneForLandscapeMode {
   // smaller spacing threshold is applied for screens equal or larger than 4.7 inches
   if (self.view.window.frame.size.height <= 321) {
     [self applySmallerSpacingForInLandscapeMode];
@@ -405,14 +405,15 @@ - (void)layoutFineTuneForRegularHorizontalSizeClass {
 - (void)viewDidLayoutSubviews {
   [super viewDidLayoutSubviews];
 
-  if (self.traitCollection.horizontalSizeClass == UIUserInterfaceSizeClassCompact) {
-    FIRLogDebug(kFIRLoggerInAppMessagingDisplay, @"I-FID300009",
-                @"Modal view rendered in compact horizontal size class mode");
-    [self layoutFineTuneForCompactHorizontalSizeClass];
-  } else {
+  if (self.traitCollection.horizontalSizeClass == UIUserInterfaceSizeClassRegular ||
+      self.traitCollection.verticalSizeClass == UIUserInterfaceSizeClassCompact) {
     FIRLogDebug(kFIRLoggerInAppMessagingDisplay, @"I-FID300010",
-                @"Modal view rendered in regular horizontal size class mode");
-    [self layoutFineTuneForRegularHorizontalSizeClass];
+                @"Modal view rendered in landscape mode");
+    [self layoutFineTuneForLandscapeMode];
+  } else {
+    FIRLogDebug(kFIRLoggerInAppMessagingDisplay, @"I-FID300009",
+                @"Modal view rendered in portrait mode");
+    [self layoutFineTuneForPortraitMode];
   }
 
   // always scroll to the top in case the body area is scrollable
diff --git a/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard b/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard
index c7890e6478e..785894e6f39 100644
--- a/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard
+++ b/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="14313.18" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES">
-    <device id="ipad9_7" orientation="portrait">
+    <device id="retina5_9" orientation="landscape">
         <adaptation id="fullscreen"/>
     </device>
     <dependencies>
@@ -18,7 +18,7 @@
                         <viewControllerLayoutGuide type="bottom" id="8Ta-Lb-9Rg"/>
                     </layoutGuides>
                     <view key="view" contentMode="scaleToFill" id="ef6-R8-q1S">
-                        <rect key="frame" x="0.0" y="0.0" width="768" height="1024"/>
+                        <rect key="frame" x="0.0" y="0.0" width="812" height="375"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
                             <imageView userInteractionEnabled="NO" contentMode="scaleToFill" horizontalHuggingPriority="251" verticalHuggingPriority="251" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="rA8-LH-EYm">
@@ -59,11 +59,11 @@
                         <viewControllerLayoutGuide type="bottom" id="K7E-8I-Yw5"/>
                     </layoutGuides>
                     <view key="view" contentMode="scaleToFill" id="vRb-yf-OWE">
-                        <rect key="frame" x="0.0" y="0.0" width="768" height="1024"/>
+                        <rect key="frame" x="0.0" y="0.0" width="812" height="375"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
                             <imageView userInteractionEnabled="NO" contentMode="scaleToFill" horizontalHuggingPriority="251" verticalHuggingPriority="251" translatesAutoresizingMaskIntoConstraints="NO" id="VfB-vw-7up">
-                                <rect key="frame" x="5" y="23" width="60" height="60"/>
+                                <rect key="frame" x="5" y="3" width="60" height="60"/>
                                 <accessibility key="accessibilityConfiguration" identifier="banner-image-view">
                                     <bool key="isElement" value="YES"/>
                                 </accessibility>
@@ -73,14 +73,14 @@
                                 </constraints>
                             </imageView>
                             <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="Messaging Title" textAlignment="natural" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontForContentSizeCategory="YES" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="rzo-9i-rXZ">
-                                <rect key="frame" x="70" y="23" width="678" height="20.5"/>
+                                <rect key="frame" x="70" y="3" width="678" height="20.333333333333332"/>
                                 <accessibility key="accessibilityConfiguration" identifier="banner-message-title-view"/>
                                 <fontDescription key="fontDescription" style="UICTFontTextStyleHeadline"/>
                                 <nil key="textColor"/>
                                 <nil key="highlightedColor"/>
                             </label>
                             <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" text="message body" textAlignment="natural" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="GOK-vx-mU8">
-                                <rect key="frame" x="70" y="51.5" width="678" height="472.5"/>
+                                <rect key="frame" x="70" y="31.333333333333329" width="678" height="22.666666666666671"/>
                                 <accessibility key="accessibilityConfiguration" identifier="banner-body-label"/>
                                 <fontDescription key="fontDescription" style="UICTFontTextStyleBody"/>
                                 <nil key="textColor"/>
@@ -129,14 +129,14 @@
                         <viewControllerLayoutGuide type="bottom" id="1nT-S0-O8H"/>
                     </layoutGuides>
                     <view key="view" contentMode="scaleToFill" id="1pz-BP-O6T">
-                        <rect key="frame" x="0.0" y="0.0" width="768" height="1024"/>
+                        <rect key="frame" x="0.0" y="0.0" width="812" height="375"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
                             <view contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="jER-Re-ODh">
-                                <rect key="frame" x="59" y="372.5" width="650" height="279"/>
+                                <rect key="frame" x="20" y="52" width="772" height="271"/>
                                 <subviews>
                                     <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" verticalCompressionResistancePriority="1000" text="Message Title" textAlignment="center" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontForContentSizeCategory="YES" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="Edi-DJ-cR8">
-                                        <rect key="frame" x="318" y="20" width="308" height="34"/>
+                                        <rect key="frame" x="318" y="20" width="430" height="34"/>
                                         <constraints>
                                             <constraint firstAttribute="height" constant="34" identifier="titleLabelHeight" id="Gzz-dd-hYn" userLabel="Title Label Height Constraint"/>
                                         </constraints>
@@ -145,7 +145,7 @@
                                         <nil key="highlightedColor"/>
                                     </label>
                                     <imageView userInteractionEnabled="NO" contentMode="scaleToFill" horizontalHuggingPriority="251" verticalHuggingPriority="251" verticalCompressionResistancePriority="700" translatesAutoresizingMaskIntoConstraints="NO" id="c7x-Lf-M58">
-                                        <rect key="frame" x="24" y="24" width="270" height="231"/>
+                                        <rect key="frame" x="24" y="20" width="270" height="231"/>
                                         <accessibility key="accessibilityConfiguration" identifier="modal-image-view">
                                             <bool key="isElement" value="YES"/>
                                         </accessibility>
@@ -172,7 +172,7 @@
                                         </variation>
                                     </imageView>
                                     <button opaque="NO" contentMode="scaleToFill" verticalHuggingPriority="252" verticalCompressionResistancePriority="1000" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="roundedRect" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="VmW-ue-K1q">
-                                        <rect key="frame" x="409" y="202" width="126" height="36"/>
+                                        <rect key="frame" x="470" y="202" width="126" height="36"/>
                                         <accessibility key="accessibilityConfiguration" identifier="message-action-button"/>
                                         <constraints>
                                             <constraint firstAttribute="height" constant="36" identifier="maxActionButtonHeight" id="6T1-on-oWM"/>
@@ -184,7 +184,7 @@
                                         </connections>
                                     </button>
                                     <textView clipsSubviews="YES" clearsContextBeforeDrawing="NO" multipleTouchEnabled="YES" contentMode="scaleToFill" editable="NO" text="Lorem ipsum dolor sit er elit lamet, consectetaur cillium adipisicing pecu, sed do eiusmod tempor " textAlignment="center" translatesAutoresizingMaskIntoConstraints="NO" id="24j-6H-N9j">
-                                        <rect key="frame" x="318" y="78" width="308" height="100"/>
+                                        <rect key="frame" x="318" y="78" width="430" height="100"/>
                                         <accessibility key="accessibilityConfiguration" identifier="message-body-textview"/>
                                         <constraints>
                                             <constraint firstAttribute="height" constant="100" identifier="bodyTextViewHeight" id="h2w-ub-tEc"/>
@@ -203,7 +203,7 @@
                                     <constraint firstItem="Edi-DJ-cR8" firstAttribute="leading" secondItem="c7x-Lf-M58" secondAttribute="trailing" constant="24" identifier="titleLabelSpacingAfterImageViewForRegularWidth" id="7vK-9V-j5H"/>
                                     <constraint firstAttribute="height" priority="100" constant="650" identifier="fixedMessageCardHeight" id="8Yx-fI-jXG"/>
                                     <constraint firstAttribute="height" constant="279" placeholder="YES" id="8qu-C8-A9u" userLabel="card height to make interface builder happy"/>
-                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="20" identifier="titleLabelTopPaddingForRegularWidth" id="9La-QV-ftg" userLabel="Title Top To Card View Top (?)"/>
+                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="20" identifier="titleLabelTopPaddingForRegularWidth" id="9La-QV-ftg" userLabel="Title Top To Card View Top"/>
                                     <constraint firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" constant="24" identifier="titleLabelRightPaddingForRegularWidth" id="Ait-Na-aVF"/>
                                     <constraint firstItem="VmW-ue-K1q" firstAttribute="centerX" secondItem="Edi-DJ-cR8" secondAttribute="centerX" identifier="actionButtonCenterX == titleLabelCenterX" id="C8M-PR-rUI"/>
                                     <constraint firstItem="VmW-ue-K1q" firstAttribute="centerX" secondItem="jER-Re-ODh" secondAttribute="centerX" identifier="actionButtonCenteredInCardForCompactWidth" id="CSN-TG-E9H"/>
@@ -221,7 +221,7 @@
                                     <constraint firstItem="c7x-Lf-M58" firstAttribute="leading" secondItem="Edi-DJ-cR8" secondAttribute="leading" identifier="imageViewMinX == titleLabelMinX" id="bD7-OU-bEW"/>
                                     <constraint firstItem="24j-6H-N9j" firstAttribute="leading" secondItem="Edi-DJ-cR8" secondAttribute="leading" identifier="bodyTextViewMinX == titleLabelMinX" id="fWU-5d-D4W"/>
                                     <constraint firstAttribute="bottom" relation="greaterThanOrEqual" secondItem="c7x-Lf-M58" secondAttribute="bottom" constant="24" id="ivB-jb-LVl"/>
-                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="20" identifier="imageViewVerticalTopPadding" id="pyI-1U-ujR" userLabel="Image Top To Card Top In Landscape Mode (?)"/>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="20" identifier="imageViewVerticalTopPadding" id="pyI-1U-ujR" userLabel="Image Top To Card Top In Landscape Mode"/>
                                     <constraint firstItem="24j-6H-N9j" firstAttribute="top" secondItem="Edi-DJ-cR8" secondAttribute="bottom" constant="24" identifier="bodyTextViewBelowTitleLabelForRegularWidth" id="qgb-13-uT4"/>
                                     <constraint firstAttribute="bottom" relation="greaterThanOrEqual" secondItem="VmW-ue-K1q" secondAttribute="bottom" priority="900" constant="20" identifier="actionButtonBottomPaddingForRegularWidth" id="xXr-od-zOM"/>
                                     <constraint firstItem="c7x-Lf-M58" firstAttribute="leading" secondItem="jER-Re-ODh" secondAttribute="leading" constant="24" identifier="imageViewLeftPaddingForRegularWidth" id="ysk-iC-Hz4"/>
@@ -232,10 +232,12 @@
                                         <exclude reference="8qu-C8-A9u"/>
                                         <exclude reference="Ln4-8U-D7V"/>
                                         <exclude reference="MCf-U1-0tP"/>
+                                        <exclude reference="0Fp-k2-48a"/>
                                         <exclude reference="Hm8-0s-RTs"/>
                                         <exclude reference="JUy-lx-oR6"/>
                                         <exclude reference="Kec-yq-1Pz"/>
                                         <exclude reference="bD7-OU-bEW"/>
+                                        <exclude reference="ivB-jb-LVl"/>
                                         <exclude reference="pyI-1U-ujR"/>
                                         <exclude reference="ysk-iC-Hz4"/>
                                         <exclude reference="7vK-9V-j5H"/>
@@ -293,11 +295,13 @@
                                     <mask key="constraints">
                                         <include reference="8qu-C8-A9u"/>
                                         <include reference="Ln4-8U-D7V"/>
+                                        <include reference="0Fp-k2-48a"/>
+                                        <include reference="ivB-jb-LVl"/>
                                     </mask>
                                 </variation>
                             </view>
                             <button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="akA-AE-VPc">
-                                <rect key="frame" x="689" y="352.5" width="40" height="40"/>
+                                <rect key="frame" x="772" y="32" width="40" height="40"/>
                                 <accessibility key="accessibilityConfiguration" identifier="close-button"/>
                                 <constraints>
                                     <constraint firstAttribute="width" constant="40" identifier="closeButtonWidth" id="Dwi-In-x47"/>

From 64aae701b91e0b3a9e1cd01435cee6057f00e622 Mon Sep 17 00:00:00 2001
From: Chris Tibbs <eggyeggbean@dhcp-100-76-160-117.sfo.corp.google.com>
Date: Wed, 31 Oct 2018 15:24:58 -0700
Subject: [PATCH 6/7] Update layout constraint identifiers to match titles in
 document outline for easier debugging

---
 ...IRInAppMessageDisplayStoryboard.storyboard | 86 +++++++++----------
 1 file changed, 43 insertions(+), 43 deletions(-)

diff --git a/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard b/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard
index 785894e6f39..43d591b750f 100644
--- a/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard
+++ b/Firebase/InAppMessagingDisplay/Resources/FIRInAppMessageDisplayStoryboard.storyboard
@@ -138,7 +138,7 @@
                                     <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" verticalCompressionResistancePriority="1000" text="Message Title" textAlignment="center" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontForContentSizeCategory="YES" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="Edi-DJ-cR8">
                                         <rect key="frame" x="318" y="20" width="430" height="34"/>
                                         <constraints>
-                                            <constraint firstAttribute="height" constant="34" identifier="titleLabelHeight" id="Gzz-dd-hYn" userLabel="Title Label Height Constraint"/>
+                                            <constraint firstAttribute="height" constant="34" identifier="Title Label Height Constraint" id="Gzz-dd-hYn" userLabel="Title Label Height Constraint"/>
                                         </constraints>
                                         <fontDescription key="fontDescription" style="UICTFontTextStyleTitle2"/>
                                         <nil key="textColor"/>
@@ -150,9 +150,9 @@
                                             <bool key="isElement" value="YES"/>
                                         </accessibility>
                                         <constraints>
-                                            <constraint firstAttribute="height" constant="144" identifier="imageViewRunTimeHeight" id="EeQ-n5-WE7" userLabel="actual height at runtime"/>
-                                            <constraint firstAttribute="width" constant="270" identifier="imageWidthForRegularWidth" id="lJJ-PY-Yai"/>
-                                            <constraint firstAttribute="height" priority="900" constant="230.66999999999999" placeholder="YES" identifier="heightToMakeInterfaceBuilderHappy" id="pm4-tp-Fjt" userLabel="image height to make interface builder happy"/>
+                                            <constraint firstAttribute="height" constant="144" identifier="actual height at runtime" id="EeQ-n5-WE7" userLabel="actual height at runtime"/>
+                                            <constraint firstAttribute="width" constant="270" identifier="Image Width In Landscape Mode" id="lJJ-PY-Yai"/>
+                                            <constraint firstAttribute="height" priority="900" constant="230.66999999999999" placeholder="YES" identifier="image height to make interface builder happy" id="pm4-tp-Fjt" userLabel="image height to make interface builder happy"/>
                                         </constraints>
                                         <variation key="default">
                                             <mask key="constraints">
@@ -175,7 +175,7 @@
                                         <rect key="frame" x="470" y="202" width="126" height="36"/>
                                         <accessibility key="accessibilityConfiguration" identifier="message-action-button"/>
                                         <constraints>
-                                            <constraint firstAttribute="height" constant="36" identifier="maxActionButtonHeight" id="6T1-on-oWM"/>
+                                            <constraint firstAttribute="height" constant="36" identifier="Max Action Button Height" id="6T1-on-oWM"/>
                                         </constraints>
                                         <inset key="contentEdgeInsets" minX="16" minY="9" maxX="16" maxY="9"/>
                                         <state key="normal" title="Action Button"/>
@@ -187,7 +187,7 @@
                                         <rect key="frame" x="318" y="78" width="430" height="100"/>
                                         <accessibility key="accessibilityConfiguration" identifier="message-body-textview"/>
                                         <constraints>
-                                            <constraint firstAttribute="height" constant="100" identifier="bodyTextViewHeight" id="h2w-ub-tEc"/>
+                                            <constraint firstAttribute="height" constant="100" identifier="Body Text View Height Constraint" id="h2w-ub-tEc"/>
                                         </constraints>
                                         <fontDescription key="fontDescription" style="UICTFontTextStyleBody"/>
                                         <textInputTraits key="textInputTraits" autocapitalizationType="sentences"/>
@@ -198,33 +198,33 @@
                                     <bool key="isElement" value="NO"/>
                                 </accessibility>
                                 <constraints>
-                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="top" relation="greaterThanOrEqual" secondItem="jER-Re-ODh" secondAttribute="top" constant="24" id="0Fp-k2-48a"/>
-                                    <constraint firstItem="24j-6H-N9j" firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" identifier="titleLabelMaxX == bodyTextViewMaxX" id="0aC-BE-yfJ"/>
-                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="leading" secondItem="c7x-Lf-M58" secondAttribute="trailing" constant="24" identifier="titleLabelSpacingAfterImageViewForRegularWidth" id="7vK-9V-j5H"/>
-                                    <constraint firstAttribute="height" priority="100" constant="650" identifier="fixedMessageCardHeight" id="8Yx-fI-jXG"/>
-                                    <constraint firstAttribute="height" constant="279" placeholder="YES" id="8qu-C8-A9u" userLabel="card height to make interface builder happy"/>
-                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="20" identifier="titleLabelTopPaddingForRegularWidth" id="9La-QV-ftg" userLabel="Title Top To Card View Top"/>
-                                    <constraint firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" constant="24" identifier="titleLabelRightPaddingForRegularWidth" id="Ait-Na-aVF"/>
-                                    <constraint firstItem="VmW-ue-K1q" firstAttribute="centerX" secondItem="Edi-DJ-cR8" secondAttribute="centerX" identifier="actionButtonCenterX == titleLabelCenterX" id="C8M-PR-rUI"/>
-                                    <constraint firstItem="VmW-ue-K1q" firstAttribute="centerX" secondItem="jER-Re-ODh" secondAttribute="centerX" identifier="actionButtonCenteredInCardForCompactWidth" id="CSN-TG-E9H"/>
-                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="24" identifier="titleLabelTopPaddingForCompactWidth" id="FTB-yV-c00"/>
-                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="centerY" secondItem="jER-Re-ODh" secondAttribute="centerY" identifier="imageViewCenteredVerticallyInCardView" id="Hm8-0s-RTs"/>
-                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="leading" secondItem="jER-Re-ODh" secondAttribute="leading" constant="24" identifier="titleLabelLeftPaddingForCompactWidth" id="JJo-tI-mvn"/>
-                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" identifier="imageViewMaxX == titleLabelMaxX" id="JUy-lx-oR6"/>
-                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="top" secondItem="Edi-DJ-cR8" secondAttribute="bottom" constant="24" identifier="imageViewSpacingBelowTitle" id="Kec-yq-1Pz"/>
-                                    <constraint firstAttribute="width" constant="650" identifier="cardWidthForTablet" id="Ln4-8U-D7V" userLabel="Card Width for Tablet"/>
-                                    <constraint firstAttribute="height" relation="lessThanOrEqual" constant="1000" identifier="maxCardViewHeightForRegularWidth" id="MCf-U1-0tP"/>
-                                    <constraint firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" constant="24" identifier="titleLabelRightPaddingForCompactWidth" id="RbZ-9Q-1S3"/>
-                                    <constraint firstItem="24j-6H-N9j" firstAttribute="top" secondItem="c7x-Lf-M58" secondAttribute="bottom" constant="24" identifier="bodyTextViewSpacingBelowImageViewForCompactWidth" id="RdS-Ao-GH0"/>
-                                    <constraint firstItem="VmW-ue-K1q" firstAttribute="top" secondItem="24j-6H-N9j" secondAttribute="bottom" constant="24" identifier="actionButtonSpacingBelowBodyTextView" id="Vej-p0-b6w"/>
-                                    <constraint firstAttribute="bottom" secondItem="VmW-ue-K1q" secondAttribute="bottom" constant="24" identifier="actionButtonBottomPaddingForCompactWidth" id="YoE-KS-uWS"/>
-                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="leading" secondItem="Edi-DJ-cR8" secondAttribute="leading" identifier="imageViewMinX == titleLabelMinX" id="bD7-OU-bEW"/>
-                                    <constraint firstItem="24j-6H-N9j" firstAttribute="leading" secondItem="Edi-DJ-cR8" secondAttribute="leading" identifier="bodyTextViewMinX == titleLabelMinX" id="fWU-5d-D4W"/>
-                                    <constraint firstAttribute="bottom" relation="greaterThanOrEqual" secondItem="c7x-Lf-M58" secondAttribute="bottom" constant="24" id="ivB-jb-LVl"/>
-                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="20" identifier="imageViewVerticalTopPadding" id="pyI-1U-ujR" userLabel="Image Top To Card Top In Landscape Mode"/>
-                                    <constraint firstItem="24j-6H-N9j" firstAttribute="top" secondItem="Edi-DJ-cR8" secondAttribute="bottom" constant="24" identifier="bodyTextViewBelowTitleLabelForRegularWidth" id="qgb-13-uT4"/>
-                                    <constraint firstAttribute="bottom" relation="greaterThanOrEqual" secondItem="VmW-ue-K1q" secondAttribute="bottom" priority="900" constant="20" identifier="actionButtonBottomPaddingForRegularWidth" id="xXr-od-zOM"/>
-                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="leading" secondItem="jER-Re-ODh" secondAttribute="leading" constant="24" identifier="imageViewLeftPaddingForRegularWidth" id="ysk-iC-Hz4"/>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="top" relation="greaterThanOrEqual" secondItem="jER-Re-ODh" secondAttribute="top" constant="24" identifier="Image View.top ≥ top + 24" id="0Fp-k2-48a"/>
+                                    <constraint firstItem="24j-6H-N9j" firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" identifier="Body Text View.trailing = Title Label.trailing" id="0aC-BE-yfJ"/>
+                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="leading" secondItem="c7x-Lf-M58" secondAttribute="trailing" constant="24" identifier="Title Label.leading = Image View.trailing + 24" id="7vK-9V-j5H"/>
+                                    <constraint firstAttribute="height" priority="100" constant="650" identifier="Fixed Message Card Height Constraint" id="8Yx-fI-jXG"/>
+                                    <constraint firstAttribute="height" constant="279" placeholder="YES" identifier="card height to make interface builder happy" id="8qu-C8-A9u" userLabel="card height to make interface builder happy"/>
+                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="20" identifier="Title Top To Card View Top" id="9La-QV-ftg" userLabel="Title Top To Card View Top"/>
+                                    <constraint firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" constant="24" identifier="trailing = Title Label.trailing + 24" id="Ait-Na-aVF"/>
+                                    <constraint firstItem="VmW-ue-K1q" firstAttribute="centerX" secondItem="Edi-DJ-cR8" secondAttribute="centerX" identifier="Action Button.centerX = Title Label.centerX" id="C8M-PR-rUI"/>
+                                    <constraint firstItem="VmW-ue-K1q" firstAttribute="centerX" secondItem="jER-Re-ODh" secondAttribute="centerX" identifier="Action Button.centerX = centerX" id="CSN-TG-E9H"/>
+                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="24" identifier="Title Label.top = top + 24" id="FTB-yV-c00"/>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="centerY" secondItem="jER-Re-ODh" secondAttribute="centerY" identifier="Image View.centerY = centerY" id="Hm8-0s-RTs"/>
+                                    <constraint firstItem="Edi-DJ-cR8" firstAttribute="leading" secondItem="jER-Re-ODh" secondAttribute="leading" constant="24" identifier="Title Label.leading = leading + 24" id="JJo-tI-mvn"/>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" identifier="Image View.trailing = Title Label.trailing" id="JUy-lx-oR6"/>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="top" secondItem="Edi-DJ-cR8" secondAttribute="bottom" constant="24" identifier="Image Top To Title Bottom In Portrait Mode" id="Kec-yq-1Pz"/>
+                                    <constraint firstAttribute="width" constant="650" identifier="Card Width for Tablet" id="Ln4-8U-D7V" userLabel="Card Width for Tablet"/>
+                                    <constraint firstAttribute="height" relation="lessThanOrEqual" constant="1000" identifier="Max Card Height In Landscape Mode" id="MCf-U1-0tP"/>
+                                    <constraint firstAttribute="trailing" secondItem="Edi-DJ-cR8" secondAttribute="trailing" constant="24" identifier="trailing = Title Label.trailing + 24" id="RbZ-9Q-1S3"/>
+                                    <constraint firstItem="24j-6H-N9j" firstAttribute="top" secondItem="c7x-Lf-M58" secondAttribute="bottom" constant="24" identifier="Body Text View.top = Image View.bottom + 24" id="RdS-Ao-GH0"/>
+                                    <constraint firstItem="VmW-ue-K1q" firstAttribute="top" secondItem="24j-6H-N9j" secondAttribute="bottom" constant="24" identifier="Button Top To Body Bottom Constraint" id="Vej-p0-b6w"/>
+                                    <constraint firstAttribute="bottom" secondItem="VmW-ue-K1q" secondAttribute="bottom" constant="24" identifier="Button Bottom To Container Bottom In Portrait Mode" id="YoE-KS-uWS"/>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="leading" secondItem="Edi-DJ-cR8" secondAttribute="leading" identifier="Image View.leading = Title Label.leading" id="bD7-OU-bEW"/>
+                                    <constraint firstItem="24j-6H-N9j" firstAttribute="leading" secondItem="Edi-DJ-cR8" secondAttribute="leading" identifier="Body Text View.leading = Title Label.leading" id="fWU-5d-D4W"/>
+                                    <constraint firstAttribute="bottom" relation="greaterThanOrEqual" secondItem="c7x-Lf-M58" secondAttribute="bottom" constant="24" identifier="bottom ≥ Image View.bottom + 24" id="ivB-jb-LVl"/>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="top" secondItem="jER-Re-ODh" secondAttribute="top" constant="20" identifier="Image Top To Card Top In Landscape Mode" id="pyI-1U-ujR" userLabel="Image Top To Card Top In Landscape Mode"/>
+                                    <constraint firstItem="24j-6H-N9j" firstAttribute="top" secondItem="Edi-DJ-cR8" secondAttribute="bottom" constant="24" identifier="Body Top To Title Bottom In Land Scape Mode" id="qgb-13-uT4"/>
+                                    <constraint firstAttribute="bottom" relation="greaterThanOrEqual" secondItem="VmW-ue-K1q" secondAttribute="bottom" priority="900" constant="20" identifier="bottom ≥ Action Button.bottom + 20 @900" id="xXr-od-zOM"/>
+                                    <constraint firstItem="c7x-Lf-M58" firstAttribute="leading" secondItem="jER-Re-ODh" secondAttribute="leading" constant="24" identifier="Image View.leading = leading + 24" id="ysk-iC-Hz4"/>
                                 </constraints>
                                 <variation key="default">
                                     <mask key="constraints">
@@ -304,8 +304,8 @@
                                 <rect key="frame" x="772" y="32" width="40" height="40"/>
                                 <accessibility key="accessibilityConfiguration" identifier="close-button"/>
                                 <constraints>
-                                    <constraint firstAttribute="width" constant="40" identifier="closeButtonWidth" id="Dwi-In-x47"/>
-                                    <constraint firstAttribute="height" constant="40" identifier="closeButtonHeight" id="tIe-pH-jRO"/>
+                                    <constraint firstAttribute="width" constant="40" identifier="Close button width = 40" id="Dwi-In-x47"/>
+                                    <constraint firstAttribute="height" constant="40" identifier="Close button height = 40" id="tIe-pH-jRO"/>
                                 </constraints>
                                 <state key="normal" backgroundImage="close-with-transparency.png"/>
                                 <connections>
@@ -315,14 +315,14 @@
                         </subviews>
                         <color key="backgroundColor" white="1" alpha="1" colorSpace="calibratedWhite"/>
                         <constraints>
-                            <constraint firstItem="jER-Re-ODh" firstAttribute="centerY" secondItem="1pz-BP-O6T" secondAttribute="centerY" identifier="cardViewVerticallyCenteredInSuperview" id="GSo-F2-pSS"/>
-                            <constraint firstItem="jER-Re-ODh" firstAttribute="top" relation="greaterThanOrEqual" secondItem="42w-41-Nyy" secondAttribute="bottom" constant="24" identifier="cardViewMinTopPaddingInSuperviewForRegularWidth" id="Yvr-Y4-aEK"/>
-                            <constraint firstItem="jER-Re-ODh" firstAttribute="leading" secondItem="1pz-BP-O6T" secondAttribute="leadingMargin" constant="10" identifier="cardViewLeftSpacingInLandscapePhone" id="bX2-s2-74w"/>
-                            <constraint firstItem="jER-Re-ODh" firstAttribute="top" relation="greaterThanOrEqual" secondItem="42w-41-Nyy" secondAttribute="bottom" constant="10" identifier="cardViewMinTopPaddingInSuperviewForPortraitPhone" id="fyU-hx-Wh1"/>
-                            <constraint firstItem="jER-Re-ODh" firstAttribute="leading" secondItem="1pz-BP-O6T" secondAttribute="leading" constant="20" identifier="cardViewLeftPaddingForLandscapePhone" id="kj1-PP-7nG"/>
-                            <constraint firstItem="jER-Re-ODh" firstAttribute="centerX" secondItem="1pz-BP-O6T" secondAttribute="centerX" identifier="cardViewHorizontallyCenteredInSuperview" id="m0a-I2-6sC"/>
-                            <constraint firstItem="akA-AE-VPc" firstAttribute="centerX" secondItem="jER-Re-ODh" secondAttribute="trailing" identifier="closeButtonMaxX == cardViewMaxX" id="nIB-zo-TIv"/>
-                            <constraint firstItem="akA-AE-VPc" firstAttribute="centerY" secondItem="jER-Re-ODh" secondAttribute="top" identifier="closeButtonMinY == cardViewMinY" id="va9-kv-0KG"/>
+                            <constraint firstItem="jER-Re-ODh" firstAttribute="centerY" secondItem="1pz-BP-O6T" secondAttribute="centerY" identifier="Message Card View.centerY = centerY" id="GSo-F2-pSS"/>
+                            <constraint firstItem="jER-Re-ODh" firstAttribute="top" relation="greaterThanOrEqual" secondItem="42w-41-Nyy" secondAttribute="bottom" constant="24" identifier="Message Card View.top ≥ Top Layout Guide.bottom + 24" id="Yvr-Y4-aEK"/>
+                            <constraint firstItem="jER-Re-ODh" firstAttribute="leading" secondItem="1pz-BP-O6T" secondAttribute="leadingMargin" constant="10" identifier="Message Card View.leading = leadingMargin + 10" id="bX2-s2-74w"/>
+                            <constraint firstItem="jER-Re-ODh" firstAttribute="top" relation="greaterThanOrEqual" secondItem="42w-41-Nyy" secondAttribute="bottom" constant="10" identifier="Message Card View.top ≥ Top Layout Guide.bottom + 10" id="fyU-hx-Wh1"/>
+                            <constraint firstItem="jER-Re-ODh" firstAttribute="leading" secondItem="1pz-BP-O6T" secondAttribute="leading" constant="20" identifier="Card Leading Margin In Landscape Mode" id="kj1-PP-7nG"/>
+                            <constraint firstItem="jER-Re-ODh" firstAttribute="centerX" secondItem="1pz-BP-O6T" secondAttribute="centerX" identifier="Message Card View.centerX = centerX" id="m0a-I2-6sC"/>
+                            <constraint firstItem="akA-AE-VPc" firstAttribute="centerX" secondItem="jER-Re-ODh" secondAttribute="trailing" identifier="Close Button.centerX = Message Card View.trailing" id="nIB-zo-TIv"/>
+                            <constraint firstItem="akA-AE-VPc" firstAttribute="centerY" secondItem="jER-Re-ODh" secondAttribute="top" identifier="Close Button.centerY = Message Card View.top" id="va9-kv-0KG"/>
                         </constraints>
                         <variation key="default">
                             <mask key="constraints">

From 61f948e3ff6ee937722ae1dd331729b95f01cd60 Mon Sep 17 00:00:00 2001
From: Chris Tibbs <eggyeggbean@dhcp-100-76-160-117.sfo.corp.google.com>
Date: Wed, 31 Oct 2018 16:43:23 -0700
Subject: [PATCH 7/7] Revert superfluous method name changes for layout fine
 tuning methods

---
 .../InAppMessagingDisplay/Modal/FIDModalViewController.m  | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Firebase/InAppMessagingDisplay/Modal/FIDModalViewController.m b/Firebase/InAppMessagingDisplay/Modal/FIDModalViewController.m
index 292600f3264..d8d0e9f2bcf 100644
--- a/Firebase/InAppMessagingDisplay/Modal/FIDModalViewController.m
+++ b/Firebase/InAppMessagingDisplay/Modal/FIDModalViewController.m
@@ -255,7 +255,7 @@ - (struct TitleBodyButtonHeightInfo)estimateTextBtnColumnHeightWithDisplayWidth:
 // the following two layoutFineTunexx methods make additional adjustments for the view layout
 // in portrait and landscape mode respectively. They are supposed to be triggered from
 // viewDidLayoutSubviews since certain dimension sizes are only available there
-- (void)layoutFineTuneForPortraitMode {
+- (void)layoutFineTuneInPortraitMode {
   // for tablet case, since we use a fixed card height, the reference would be just the card height
   // for non-tablet case, we want to use a dynamic height , so the reference would be the window
   // height
@@ -339,7 +339,7 @@ - (void)applySmallerSpacingForInLandscapeMode {
   }
 }
 
-- (void)layoutFineTuneForLandscapeMode {
+- (void)layoutFineTuneInLandscapeMode {
   // smaller spacing threshold is applied for screens equal or larger than 4.7 inches
   if (self.view.window.frame.size.height <= 321) {
     [self applySmallerSpacingForInLandscapeMode];
@@ -409,11 +409,11 @@ - (void)viewDidLayoutSubviews {
       self.traitCollection.verticalSizeClass == UIUserInterfaceSizeClassCompact) {
     FIRLogDebug(kFIRLoggerInAppMessagingDisplay, @"I-FID300010",
                 @"Modal view rendered in landscape mode");
-    [self layoutFineTuneForLandscapeMode];
+    [self layoutFineTuneInLandscapeMode];
   } else {
     FIRLogDebug(kFIRLoggerInAppMessagingDisplay, @"I-FID300009",
                 @"Modal view rendered in portrait mode");
-    [self layoutFineTuneForPortraitMode];
+    [self layoutFineTuneInPortraitMode];
   }
 
   // always scroll to the top in case the body area is scrollable