Add support for other Firebase products to integrate with Remote Config. #6692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenyz
reviewed
Oct 8, 2020
|
|
||
| /// Adds a listener that will be called whenever one of the get methods is called. | ||
| /// @param listener Function that takes in the parameter key and the config. | ||
| - (void)addListener:(void (^_Nonnull)(NSString *_Nonnull, NSDictionary *_Nonnull))listener; |
There was a problem hiding this comment.
should remove this from the header file since we're just calling it internally within the RC SDK and not changing the public API
karenyz
reviewed
Oct 8, 2020
| @@ -284,6 +306,14 @@ - (void)loadConfigFromMainTable { | |||
| self->_defaultConfig = [defaultConfig mutableCopy]; | |||
| dispatch_semaphore_signal(self->_configLoadFromDBSemaphore); | |||
| }]; | |||
|
|
|||
| [_DBManager loadPersonalizationWithCompletionHandler:^(BOOL success, NSDictionary *fetchedConfig, | |||
There was a problem hiding this comment.
rename to fetchedPersonalization and activePersonalization?
karenyz
reviewed
Oct 8, 2020
|
|
||
| if (handler) { | ||
| dispatch_async(dispatch_get_main_queue(), ^{ | ||
| handler(YES, activePersonalization, fetchedPersonalization, nil); |
There was a problem hiding this comment.
I think the handler definition expects fetched and then active
There was a problem hiding this comment.
LOL, too much copying and pasting.
karenyz
reviewed
Oct 8, 2020
| @@ -331,6 +358,10 @@ - (FIRRemoteConfigValue *)configValueForKey:(NSString *)key { | |||
| @"Key %@ should come from source:%zd instead coming from source: %zd.", key, | |||
| (long)FIRRemoteConfigSourceRemote, (long)value.source); | |||
| } | |||
| if ([self->_configContent.activePersonalization count] > 0) { | |||
| [self callListeners:value.stringValue | |||
| metadata:self->_configContent.activePersonalization[key]]; | |||
There was a problem hiding this comment.
thinking: we mentioned that the listener approach would allow us to add other side-effects in the future, but given the current implementation all the listeners would be called specifically with personalization metadata, which limits the functionality we can add
Stores Personalization metadata in database along with Remote Config parameters. Adds a RCNPersonalization class that logs Personalization events, and listeners that call that when get*() is called.