Skip to content

Dispatch getData callbacks on FRepo callback queue #8247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 16, 2021
Merged

Dispatch getData callbacks on FRepo callback queue #8247

merged 7 commits into from
Jul 16, 2021

Conversation

jmwski
Copy link
Contributor

@jmwski jmwski commented Jun 11, 2021

@google-cla google-cla bot added the cla: yes label Jun 11, 2021
@jmwski jmwski requested a review from puf June 11, 2021 23:32
@google-oss-bot
Copy link

google-oss-bot commented Jun 11, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    SDK overall coverage changed from ? (44a1595) to 56.82% (9a610f9) by ?.

    Click to show coverage changes in 102 files.
    Filename Base (44a1595) Head (9a610f9) Diff
    APLevelDB.mm ? 61.56% ?
    FAckUserWrite.m ? 83.78% ?
    FArraySortedDictionary.m ? 97.60% ?
    FAtomicNumber.m ? 100.00% ?
    FCacheNode.m ? 100.00% ?
    FCachePolicy.m ? 17.14% ?
    FCancelEvent.m ? 0.00% ?
    FChange.m ? 88.24% ?
    FChildChangeAccumulator.m ? 65.22% ?
    FChildEventRegistration.m ? 0.00% ?
    FChildrenNode.m ? 90.93% ?
    FClock.m ? 100.00% ?
    FCompoundHash.m ? 97.92% ?
    FCompoundWrite.m ? 91.45% ?
    FConnection.m ? 28.03% ?
    FDataEvent.m ? 28.57% ?
    FEmptyNode.m ? 100.00% ?
    FEventEmitter.m ? 0.00% ?
    FEventGenerator.m ? 95.69% ?
    FEventRaiser.m ? 33.33% ?
    FIRDataSnapshot.m ? 89.86% ?
    FIRDatabase.m ? 14.83% ?
    FIRDatabaseComponent.m ? 16.95% ?
    FIRDatabaseConfig.m ? 60.38% ?
    FIRDatabaseConnectionContextProvider.m ? 96.47% ?
    FIRDatabaseQuery.m ? 4.13% ?
    FIRDatabaseReference.m ? 6.47% ?
    FIRMutableData.m ? 75.51% ?
    FIRRetryHelper.m ? 83.72% ?
    FIRServerValue.m ? 0.00% ?
    FIRTransactionResult.m ? 0.00% ?
    FImmutableSortedDictionary.m ? 31.03% ?
    FImmutableSortedSet.m ? 54.22% ?
    FImmutableTree.m ? 85.54% ?
    FIndex.m ? 91.67% ?
    FIndexedFilter.m ? 96.60% ?
    FIndexedNode.m ? 97.14% ?
    FKeepSyncedEventRegistration.m ? 0.00% ?
    FKeyIndex.m ? 62.16% ?
    FLLRBEmptyNode.m ? 75.00% ?
    FLLRBValueNode.m ? 86.01% ?
    FLeafNode.m ? 85.00% ?
    FLevelDBStorageEngine.m ? 73.55% ?
    FLimitedFilter.m ? 95.63% ?
    FListenComplete.m ? 0.00% ?
    FMaxNode.m ? 60.61% ?
    FMerge.m ? 88.10% ?
    FNamedNode.m ? 63.38% ?
    FNextPushId.m ? 63.30% ?
    FOperationSource.m ? 89.29% ?
    FOverwrite.m ? 81.48% ?
    FPath.m ? 94.04% ?
    FPathIndex.m ? 87.80% ?
    FPendingPut.m ? 0.00% ?
    FPersistenceManager.m ? 58.93% ?
    FPersistentConnection.m ? 21.69% ?
    FPriorityIndex.m ? 87.01% ?
    FPruneForest.m ? 90.80% ?
    FQueryParams.m ? 96.59% ?
    FQuerySpec.m ? 87.76% ?
    FRangeMerge.m ? 94.69% ?
    FRangedFilter.m ? 90.36% ?
    FRepo.m ? 13.62% ?
    FRepoInfo.m ? 73.15% ?
    FRepoManager.m ? 30.20% ?
    FSRWebSocket.m ? 39.95% ?
    FServerValues.m ? 49.21% ?
    FSnapshotHolder.m ? 100.00% ?
    FSnapshotUtilities.m ? 62.14% ?
    FSparseSnapshotTree.m ? 97.41% ?
    FStringUtilities.m ? 74.42% ?
    FSyncPoint.m ? 87.31% ?
    FSyncTree.m ? 72.26% ?
    FTrackedQuery.m ? 75.76% ?
    FTrackedQueryManager.m ? 90.40% ?
    FTransformedEnumerator.m ? 100.00% ?
    FTree.m ? 5.92% ?
    FTreeNode.m ? 100.00% ?
    FTreeSortedDictionary.m ? 96.42% ?
    FTreeSortedDictionaryEnumerator.m ? 100.00% ?
    FTupleNodePath.m ? 0.00% ?
    FTupleObjectNode.m ? 0.00% ?
    FTuplePathValue.m ? 100.00% ?
    FTupleRemovedQueriesEvents.m ? 100.00% ?
    FTupleSetIdPath.m ? 0.00% ?
    FTupleStringNode.m ? 0.00% ?
    FTupleTransaction.m ? 0.00% ?
    FTupleUserCallback.m ? 0.00% ?
    FUtilities.m ? 74.61% ?
    FValidation.m ? 26.42% ?
    FValueEventRegistration.m ? 0.00% ?
    FValueIndex.m ? 49.28% ?
    FView.m ? 80.31% ?
    FViewCache.m ? 100.00% ?
    FViewProcessor.m ? 91.66% ?
    FViewProcessorResult.m ? 100.00% ?
    FWebSocketConnection.m ? 42.75% ?
    FWriteRecord.m ? 46.24% ?
    FWriteTree.m ? 75.63% ?
    FWriteTreeRef.m ? 100.00% ?
    NSData+SRB64Additions.m ? 85.71% ?
    fbase64.c ? 28.92% ?

Test Logs

schmidt-sebastian
schmidt-sebastian reviewed Jun 15, 2021
View reviewed changes
@jmwski jmwski assigned schmidt-sebastian and unassigned jmwski Jun 18, 2021
@jmwski jmwski enabled auto-merge (squash) June 24, 2021 01:02
paulb777
paulb777 reviewed Jul 8, 2021
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IanWyszynski Is there anything blocking this PR's progress? If not, please update the Changelog to release in 8.4.0 and merge.

@jmwski
Copy link
Contributor Author

jmwski commented Jul 8, 2021 •
edited
Loading

@IanWyszynski Is there anything blocking this PR's progress? If not, please update the Changelog to release in 8.4.0 and merge.

@schmidt-sebastian, could you approve this? I've added a test that callbacks happen on the main thread. Also updated the changelog.

github-actions[bot]
github-actions bot reviewed Jul 8, 2021
View reviewed changes
github-actions[bot]
github-actions bot reviewed Jul 8, 2021
View reviewed changes
github-actions[bot]
github-actions bot reviewed Jul 8, 2021
View reviewed changes
github-actions[bot]
github-actions bot reviewed Jul 8, 2021
View reviewed changes
github-actions[bot]
github-actions bot reviewed Jul 8, 2021
View reviewed changes
schmidt-sebastian
schmidt-sebastian approved these changes Jul 15, 2021
View reviewed changes
@jmwski jmwski merged commit 41b0073 into master Jul 16, 2021
@jmwski jmwski deleted the jw/callbacks branch July 16, 2021 12:48
@paulb777 paulb777 mentioned this pull request Jul 16, 2021
Closed
@firebase firebase locked and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@puf puf Awaiting requested review from puf

+1 more reviewer

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jmwski jmwski

Labels
api: database cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmwski @google-oss-bot @paulb777 @schmidt-sebastian