-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Description
Step 0: Are you in the right place?
- For issues or feature requests related to the code in this repository
file a Github issue.- If this is a feature request please use the Feature Request template.
- For general technical questions, post a question on StackOverflow
with thefirebase
tag. - For general (non-iOS) Firebase discussion, use the firebase-talk
google group. - For backend issues, console issues, and other non-SDK help that does not fall under one
of the above categories, reach out to
Firebase Support. - Once you've read this section and determined that your issue is appropriate for
this repository, please delete this section.
[REQUIRED] Step 1: Describe your environment
- Xcode version: 12.5.1
- Firebase SDK version:8.6.0
- Installation method:
CocoaPods
- Firebase Component: App Distribution (Auth, Core, Database, Firestore, Messaging, Storage, etc)
[REQUIRED] Step 2: Describe the problem
Steps to reproduce:
The documentation for the releaseNotes property on FIRAppDistributionRelease indicates it is non-null https://firebase.google.com/docs/reference/ios/firebaseappdistribution/api/reference/Classes/FIRAppDistributionRelease#releasenotes
However, in practice the property may be null? invertase/react-native-firebase#5667
Now, it may well be this is my incorrect interpretation of what non-null means in objective-c as a modifier on a property, perhaps what it means is that you cannot attempt to set it to null, but if accessed (without ever being set) it is potentially null.
If so, apologies for the noise, please close, and I've learned something (and thank you)
But if this is an issue it should be fixed either in documentation or code or where ever the data is initiall provided I guess
Relevant Code:
Crash report in linked react-native-firebase issue, but:
resolve(@{
@"displayVersion" : release.displayVersion,
@"buildVersion" : release.buildVersion,
@"releaseNotes" : release.releaseNotes,
@"isExpired" : [NSNumber numberWithBool:release.isExpired],
@"downloadURL" : release.downloadURL
});
If you do that, the releaseNotes property will potentially be nil