Skip to content

Auth: Remove all #ifs in favor of API_UNAVAILABLE #8451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 30, 2021
Merged

Auth: Remove all #ifs in favor of API_UNAVAILABLE #8451

merged 7 commits into from
Jul 30, 2021

Conversation

morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented Jul 28, 2021 •
edited
Loading

Need to add headerdoc comments with platform availability where it's limited before merging this PR.

@google-cla google-cla bot added the cla: yes label Jul 28, 2021
paulb777
paulb777 reviewed Jul 28, 2021
View reviewed changes
@google-oss-bot
Copy link

google-oss-bot commented Jul 28, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseAuth-iOS-FirebaseAuth.framework

    SDK overall coverage changed from 68.68% (3a5bdd8) to 68.69% (04ffb76) by +0.01%.

    Filename Base (3a5bdd8) Head (04ffb76) Diff
    FIRAuthKeychainServices.m 59.38% 60.16% +0.78%

Test Logs

paulb777
paulb777 reviewed Jul 28, 2021
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - deferring approval to @rosalyntan

@morganchen12 morganchen12 marked this pull request as ready for review July 29, 2021 21:57
@morganchen12 morganchen12 requested a review from rosalyntan July 29, 2021 21:57
@morganchen12 morganchen12 added this to the 8.6.0 - M102 milestone Jul 29, 2021
@morganchen12 morganchen12 merged commit 9b4c5c0 into master Jul 30, 2021
@morganchen12 morganchen12 deleted the mc/api branch July 30, 2021 16:20
@firebase firebase locked and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 left review comments

@rosalyntan rosalyntan rosalyntan approved these changes

Assignees
No one assigned
Labels
api: auth cla: yes public-api-change
Projects
None yet
Milestone
8.6.0 - M102
Development

Successfully merging this pull request may close these issues.
4 participants
@morganchen12 @google-oss-bot @paulb777 @rosalyntan