Check token is different from cache and storage before updating it #7223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
reviewed
Dec 28, 2020
| scope:kFIRInstanceIDDefaultTokenScope]; | ||
| NSString *cachedToken = cachedTokenInfo.token; | ||
|
|
||
| if (self.defaultFCMToken.length != tokenUpdatedFromMessaging.length || |
There was a problem hiding this comment.
Why are the length checks needed? Aren't two isEqualToString checks sufficient?
There was a problem hiding this comment.
In case both are null, then [null isEqualtoString: null] return false, even though it should be true.
paulb777
approved these changes
Dec 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When messaging updates token and notifying InstanceID, instanceID should first check to see the token from Messaging is different than the one in local cache or in the database.
This extra check helps reduce storage writing in the future when we remove InstanceID and handle token completely from Messaging.