Skip to content

Add AppDistribution to SwiftPM. #7045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 2, 2020
Merged

Add AppDistribution to SwiftPM. #7045

merged 10 commits into from
Dec 2, 2020

Conversation

ryanwilson
Copy link
Member

@ryanwilson ryanwilson commented Nov 26, 2020 •
edited
Loading

Tests aren't ported yet due to an import OCMock issue.
Tests are now ported.

@ryanwilson
Add AppDistribution to SwiftPM.
0099a22 
Tests aren't ported yet due to an import OCMock issue.
@google-cla google-cla bot added the cla: yes label Nov 26, 2020
@ryanwilson ryanwilson requested review from jeremydurham and paulb777 and removed request for jeremydurham November 26, 2020 21:18
@ryanwilson
Copy link
Member Author

No rush for review until after Thanksgiving holidays of course!

@jeremydurham
Copy link
Contributor

@ryanwilson Thank you for doing this!

paulb777
paulb777 approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the OCMock issue?

Add a CHANGELOG update for 7.3.0

@ryanwilson
Copy link
Member Author

What's the OCMock issue?

The #import <OCMock/OCMock.h> imports were failing, but @import OCMock; passes. I was under the impression it was a common issue with SwiftPM since the other products I saw didn't have unit tests added. Maybe I missed something?

Add a CHANGELOG update for 7.3.0

Will do.

@paulb777
Copy link
Member

#import "OCMock.h" works with both

@paulb777
Copy link
Member

I'm ok to defer tests to a future PR though

@ryanwilson
Copy link
Member Author

I'm ok to defer tests to a future PR though

I added tests in this PR so I wouldn't forget eventually :P

@ryanwilson ryanwilson requested a review from paulb777 December 2, 2020 13:24
@ryanwilson ryanwilson merged commit a608663 into master Dec 2, 2020
@ryanwilson ryanwilson deleted the rw-appdistro-swiftpm branch December 2, 2020 16:51
@firebase firebase locked and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremydurham jeremydurham jeremydurham approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: appdistribution api: core cla: yes Swift Package Manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanwilson @jeremydurham @paulb777 @google-oss-bot