Skip to content

Only log the URL follow event in messageClicked:withAction: if there's a URL to follow #5564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2020
Merged

Only log the URL follow event in messageClicked:withAction: if there's a URL to follow #5564

merged 2 commits into from
May 11, 2020

Conversation

christibbs
Copy link
Contributor

Fix for internal bug #155959022 to not count clicks if an in-app messaging campaign has no URL to follow.

@google-oss-bot google-oss-bot added the api: inappmessaging Firebase In App Messaging label May 11, 2020
@JasonAHeron
Copy link

LGTM

@christibbs christibbs merged commit a2d6fac into master May 11, 2020
@firebase firebase locked and limited conversation to collaborators Jun 11, 2020
@paulb777 paulb777 deleted the fiam-fix-click branch August 19, 2020 00:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@JasonAHeron JasonAHeron JasonAHeron left review comments

@rohandandavati rohandandavati rohandandavati approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: inappmessaging Firebase In App Messaging cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@christibbs @JasonAHeron @rohandandavati @googlebot @google-oss-bot