Skip to content

Revert "Raise exception when log into Facebook using OAuth. (#3138)" #3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2019
Merged

Revert "Raise exception when log into Facebook using OAuth. (#3138)" #3208

merged 1 commit into from
Jun 18, 2019

Conversation

renkelvin
Copy link
Contributor

@renkelvin renkelvin commented Jun 18, 2019 •
edited by ryanwilson
Loading

This is likely a breaking change and an error should be logged instead.

@renkelvin renkelvin requested a review from ryanwilson June 18, 2019 18:47
@renkelvin renkelvin merged commit 227f856 into master Jun 18, 2019
@renkelvin renkelvin deleted the revert-oauth-facebook branch June 18, 2019 18:59
ryanwilson pushed a commit that referenced this pull request Jun 18, 2019
@renkelvin @ryanwilson
Revert "Raise exception when log into Facebook using OAuth. (#3138)" (#…
8e840ea 
…3208)

This reverts commit 393d060.
@ryanwilson ryanwilson mentioned this pull request Jun 18, 2019
Merged
ryanwilson added a commit that referenced this pull request Jun 18, 2019
@ryanwilson
Revert "Raise exception when log into Facebook using OAuth. (#3138)" (#…
52e6dee 
…3208) (#3209)

This reverts commit 393d060.
ryanwilson added a commit that referenced this pull request Jun 19, 2019
@ryanwilson
Merging the 6.3.0 release into master (#3217)
3374daa 
* Update versions for Release 6.3.0

* Revert "Raise exception when log into Facebook using OAuth.  (#3138)" (#3208) (#3209)

This reverts commit 393d060.
@renkelvin renkelvin mentioned this pull request Aug 2, 2019
Merged
@paulb777 paulb777 added this to the 6.7.0 milestone Aug 12, 2019
@firebase firebase locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
6.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@renkelvin @ryanwilson @paulb777 @googlebot