Skip to content

Unify naming of keychain services and user defaults #3473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 31, 2019
Merged

Unify naming of keychain services and user defaults #3473

merged 4 commits into from
Jul 31, 2019

Conversation

renkelvin
Copy link
Contributor

Keychain => KeychainServices
UserDefaultsStorage => UserDefaults

@renkelvin
Unify naming of keychain services and user defaults
8209c0b 
Keychain => KeychainServices
UserDefaultsStorage => UserDefaults
@renkelvin renkelvin requested a review from morganchen12 July 30, 2019 22:58
@renkelvin renkelvin merged commit a55467a into master Jul 31, 2019
@renkelvin renkelvin deleted the naming branch July 31, 2019 20:24
@firebase firebase locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renkelvin @morganchen12 @googlebot