Skip to content

dataconnect: change grpc api version from "v1beta" to "v1" #6729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 27, 2025
Merged

dataconnect: change grpc api version from "v1beta" to "v1" #6729

merged 4 commits into from
Feb 27, 2025

Conversation

dconeybe
Copy link
Contributor

The gRPC proto requests are changed to using the v1 endpoint, instead of the v1beta endpoint.

If interested, see #6299 for the similar change from v1alpha to v1beta.

@dconeybe dconeybe self-assigned this Feb 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dconeybe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the gRPC proto requests to use the v1 endpoint instead of the v1beta endpoint. This change affects the CHANGELOG.md, dataconnect.yaml files in both the demo and emulator directories, and the connector_service.proto and graphql_error.proto files.

Highlights

  • API Version Update: The core change is the update from v1beta to v1 in the gRPC proto package, reflecting a move to a more stable API version.
  • Configuration Updates: The specVersion field in the dataconnect.yaml files for both the demo and emulator environments has been updated to v1.
  • Proto Package Update: The proto files connector_service.proto and graphql_error.proto have their package declarations updated from google.firebase.dataconnect.v1beta to google.firebase.dataconnect.v1.
  • Changelog Update: The CHANGELOG.md file has been updated to reflect the gRPC proto package change to v1.

Changelog

  • firebase-dataconnect/CHANGELOG.md
    • Added a changelog entry indicating the gRPC proto package has been changed to v1 from v1beta.
  • firebase-dataconnect/demo/firebase/dataconnect/dataconnect.yaml
    • Updated specVersion from v1beta to v1.
  • firebase-dataconnect/emulator/dataconnect/dataconnect.yaml
    • Updated specVersion from v1beta to v1.
  • firebase-dataconnect/src/main/proto/google/firebase/dataconnect/proto/connector_service.proto
    • Updated the package declaration from google.firebase.dataconnect.v1beta to google.firebase.dataconnect.v1.
  • firebase-dataconnect/src/main/proto/google/firebase/dataconnect/proto/graphql_error.proto
    • Updated the package declaration from google.firebase.dataconnect.v1beta to google.firebase.dataconnect.v1.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Trivia time!

What is Protocol Buffers (protobuf) and who developed it?

Click here for the answer
Protocol Buffers (protobuf) is a language-neutral, platform-neutral extensible mechanism for serializing structured data. It was developed by Google.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩