Skip to content

Commit 6f9f420

Browse files
linsunmandarjog
authored andcommitted
loose the validation on istioctl to allow users to pass config (istio#5955)
* remove the unecessary check
1 parent f7831f4 commit 6f9f420

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

istioctl/cmd/istioctl/inject.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,7 @@ func validateFlags() error {
113113
if meshConfigFile == "" && meshConfigMapName == "" {
114114
err = multierr.Append(err, errors.New("--meshConfigFile or --meshConfigMapName must be set"))
115115
}
116-
if injectConfigFile != "" && injectConfigMapName != "" {
117-
err = multierr.Append(err, errors.New("--injectConfigFile and --injectConfigMapName are mutually exclusive"))
118-
}
116+
119117
err = multierr.Append(err, inject.ValidateIncludeIPRanges(includeIPRanges))
120118
err = multierr.Append(err, inject.ValidateExcludeIPRanges(excludeIPRanges))
121119
err = multierr.Append(err, inject.ValidateIncludeInboundPorts(includeInboundPorts))

0 commit comments

Comments
 (0)