This repository was archived by the owner on Dec 13, 2023. It is now read-only.

Description
No checks are performed for missing TOML sections
Overview
- OS name and version.
N/A
go version output
N/A
waflyctl --version in recent releases or brew info waflyctl output.
Fastly WAF Control Tool version: 0.2.1 built on 2018-11-09T16:21:56Z by #team-soc
- Description of the problem. What is happening that shouldn't?
I did not want to create any logging endpoints and commented out the [weblogs] and [waflogs] sections. waflyctl tried to create the logging endpoints with the default object values and an error resulted. (See below)
- Description of the expected behaviour.
If no logging endpoint configuration information is provided, I would have like waflyctl to skip the creation of a logging endpoint altogether.
- Exact steps to reproduce the error.
Delete or comment out the [weblogs] and [waflogs] sections of a toml file and run waflyctl.
Additional Information:
- Logs showing errors or behaviour.
400 - Bad Request:
Title: Bad request
Detail: Need either 'ipv4' or 'ipv6' or 'hostname'ERROR: 2018/12/20 15:42:26 waflyctl.go:967: Fatal issue creating logging settings..`
- Steps which have been taken to try address the issue.
I ended up putting the [weblogs] and [waflogs] sections of a toml file back with minimal values and ran into another problem, which will be documented in a separate issue.
- Other data which indicates what may be causing the issue.
N/A
- Stack trace if any error is seen.
N/A