Skip to content

Conversation

@remidewitte
Copy link
Contributor

@remidewitte remidewitte commented May 29, 2024

I don't really know if it is the right approach neither how to do a proper test case yet. Please advise :)

The main use case is to get a proper name in fastify instead of bound _encapsulateThreeParam:

ERROR (32467): Uncaught Exception: A callback for 'onReady' hook timed out. You may have forgotten to call 'done' function or to resolve a Promise
    err: {
      "type": "FastifyError",
      "message": "A callback for 'onReady' hook timed out. You may have forgotten to call 'done' function or to resolve a Promise: Plugin did not start in time: 'bound _encapsulateThreeParam'. You may have forgotten to call 'done' function or to resolve a Promise",
      "stack":
          FastifyError: A callback for 'onReady' hook timed out. You may have forgotten to call 'done' function or to resolve a Promise

Checklist

@mcollina
Copy link
Member

As you imagine, this needs a unit test. Start developing a tiny app using avvio that shows the problem. Once you have it failing, your transform it in a new test file with tap.

@remidewitte remidewitte force-pushed the on-ready-unwrapped-name branch from bf3417e to 45afcde Compare May 29, 2024 14:34
@remidewitte
Copy link
Contributor Author

Thanks. I found the way to implement this unit test !

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 2075e4b into fastify:master Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants