Skip to content

Add opt-out for eslint-webpack-plugin #10170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iansu merged 1 commit into from
Feb 3, 2021
Merged

Add opt-out for eslint-webpack-plugin #10170

iansu merged 1 commit into from
Feb 3, 2021

Conversation

@mrmckeb
Copy link
Contributor

@mrmckeb mrmckeb commented Nov 29, 2020 •
edited
Loading

This PR adds two new flags, documented under "Advanced Configuration".

  • ESLINT_NO_DEV_ERRORS - converts errors to warnings in development (no error overlay).
  • DISABLE_ESLINT_PLUGIN - the plugin is completely disabled. This will also bring performance benefits for some users.

It was tested with a mixture of warnings and errors, both flags were tested individually.

Resolves #9887.

@chrisahardie
Copy link

chrisahardie commented Nov 30, 2020

Instead of removing the plugin entirely, would it be better just to flip the switch on the failOnError option?