docs: Replace var with let or const (#19511)

larkceresin · web-flow · commit 83e24f5be4d5 · 2025-03-13T10:13:32.000+01:00
* chore: update no-unreachable

* chore: update rule no-unreachable-loop

* remove const- unecessary

* add let

* doc: replace var back in no-unreachable. with as written, breaks otherwise.
diff --git a/docs/src/rules/no-unreachable-loop.md b/docs/src/rules/no-unreachable-loop.md
@@ -56,7 +56,7 @@ function verifyList(head) {
 }
 
 function findSomething(arr) {
-    for (var i = 0; i < arr.length; i++) {
+    for (let i = 0; i < arr.length; i++) {
         if (isSomething(arr[i])) {
             return arr[i];
         } else {
@@ -110,7 +110,7 @@ function verifyList(head) {
 }
 
 function findSomething(arr) {
-    for (var i = 0; i < arr.length; i++) {
+    for (let i = 0; i < arr.length; i++) {
         if (isSomething(arr[i])) {
             return arr[i];
         }
@@ -184,7 +184,7 @@ Examples of **correct** code for this rule with the `"ignore"` option:
 ```js
 /*eslint no-unreachable-loop: ["error", { "ignore": ["ForInStatement", "ForOfStatement"] }]*/
 
-for (var key in obj) {
+for (let key in obj) {
   hasEnumerableProperties = true;
   break;
 }

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ function verifyList(head) {`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`function findSomething(arr) {`
`59`		`- for (var i = 0; i < arr.length; i++) {`
	`59`	`+ for (let i = 0; i < arr.length; i++) {`
`60`	`60`	`if (isSomething(arr[i])) {`
`61`	`61`	`return arr[i];`
`62`	`62`	`} else {`
`@@ -110,7 +110,7 @@ function verifyList(head) {`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`function findSomething(arr) {`
`113`		`- for (var i = 0; i < arr.length; i++) {`
	`113`	`+ for (let i = 0; i < arr.length; i++) {`
`114`	`114`	`if (isSomething(arr[i])) {`
`115`	`115`	`return arr[i];`
`116`	`116`	`}`
@@ -184,7 +184,7 @@ Examples of correct code for this rule with the `"ignore"` option:
`184`	`184`	```js
`185`	`185`	`/eslint no-unreachable-loop: ["error", { "ignore": ["ForInStatement", "ForOfStatement"] }]/`
`186`	`186`
`187`		`-for (var key in obj) {`
	`187`	`+for (let key in obj) {`
`188`	`188`	`hasEnumerableProperties = true;`
`189`	`189`	`break;`
`190`	`190`	`}`