HTTPS support for erlcloud_sns #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include/erlcloud_aws.hrl
Outdated
There was a problem hiding this comment.
Can we make this scheme and "http://" like we do for the other services? I see that will make the implementation a little harder, but I think it is worth it for some API consistency. Thanks.
There was a problem hiding this comment.
That makes sense. Stay tuned for tests+changes!
|
Hold up! I've introduced a bug! |
|
Okay, that was a false flag. My upstream application hadn't reloaded the newest erlcloud *beams and was giving me strangely concatenated URLs. |
ransomr
pushed a commit
that referenced
this pull request
Oct 2, 2014
HTTPS support for erlcloud_sns
|
Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements HTTPS support as outlined in Issue #116.