public_key: Add support for ExtensionRequest #10031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 17 suites 4m 43s ⏱️ Results for commit 5f88033. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
c29bdd7 to
94ebbb9
Compare
94ebbb9 to
086bf9d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for the legacy PKCS-9 ExtensionRequest by adding modern ASN.1 modules and wiring up encode/decode fallbacks.
- Add new ASN.1 specs: EnrollmentMessageSyntax-2009 and PKIXCRMF-2009
- Update
public_key.erlto handle'ExtensionReq'/'ExtensionRequest'inder_encode/der_decode - Extend tests, application config, include files, and Makefiles to build and verify the new support
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/public_key/test/public_key_SUITE.erl | Added pkix_extensionreq tests for DER-encode of ExtensionReq |
| lib/public_key/src/public_key.erl | Implemented der_encode/der_decode fallbacks for ExtensionRequest |
| lib/public_key/src/public_key.app.src | Included new ASN.1 modules in application definition |
| lib/public_key/include/public_key.hrl | Updated PKCS-9 comment for pkcs-9-at-extensionRequest OID |
| lib/public_key/asn1/Makefile | Added EnrollmentMessageSyntax-2009 and PKIXCRMF-2009 to build list |
| lib/public_key/asn1/EnrollmentMessageSyntax-2009.asn1 | New ASN.1 specification for ExtensionReq |
| lib/public_key/asn1/PKIXCRMF-2009.asn1 | New ASN.1 specification to support CRMF components |
Comments suppressed due to low confidence (2)
lib/public_key/test/public_key_SUITE.erl:1580
- The test currently only verifies DER-encode behavior. Add a complementary assertion invoking
public_key:der_decode('ExtensionRequest', Expected)and matching its result to the expected term to ensure decode support is covered.
Expected = <<48,0>>,
lib/public_key/src/public_key.erl:581
- [nitpick] Add a brief function-level comment above this clause to document that
'ExtensionRequest'is mapped to'ExtensionReq'for backwards compatibility, aiding future maintainers.
der_decode('ExtensionRequest', Value) ->
cbb64ab to
63bf05b
Compare
08f69df to
965949e
Compare
u3s
previously approved these changes
Jul 14, 2025
965949e to
9f1fbe4
Compare
u3s
reviewed
Jul 15, 2025
lib/public_key/src/public_key.erl
Outdated
| error:{badmatch, {error, _}} = Error -> | ||
| erlang:error(Error) | ||
| end; | ||
| %% Bakwards compatibility |
There was a problem hiding this comment.
global typo, which you fixed above not here. run grep please.
There was a problem hiding this comment.
@u3s I did, maybe it was that it was the first word here so that it started with B and not b ! Fixed anyhow please re-approve.
u3s
previously approved these changes
Jul 15, 2025
Add modern ASN-1 specs to be able to retain support for ExtensionRequest from legacy PKCS-9 spec. This can open up for further support of EnrollmentMessageSyntax-2009 being added later. Also add some missing backwards compatibility for X520CommonName and legacy AttributeTypeAndValue Closes erlang#10028
9f1fbe4 to
5f88033
Compare
u3s
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add modern ASN-1 specs to be able to retain support for ExtensionRequest from legacy PKCS-9 spec.
This can open up for further support being added later.
Closes #10028