Skip to content

Conversation

@Aditya7880900936
Copy link
Contributor

What type of PR is this?

fix(crd): correct EnvoyPatchPolicy printer columns

What this PR does / why we need it:

This PR fixes the additionalPrinterColumns configuration for the
EnvoyPatchPolicy CRD.

Previously, the STATUS column was empty because the printer column
referenced a non-existent field under .status.conditions.
EnvoyPatchPolicy follows Gateway API conventions and stores conditions
under .status.ancestors[].conditions.

This change updates the printer columns to reference condition status
under .status.ancestors[].conditions, so
kubectl get envoypatchpolicies correctly shows Accepted and Programmed
states.

Which issue(s) this PR fixes:

Fixes #7745

Release Notes: No

@Aditya7880900936 Aditya7880900936 requested a review from a team as a code owner December 18, 2025 15:52
Copy link

@chaima-belhedi chaima-belhedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx for taking care of this @Aditya7880900936

@Aditya7880900936
Copy link
Contributor Author

Thanks a lot for the review and approval! Appreciate your time and guidance @chaima-belhedi

@arkodg
Copy link
Contributor

arkodg commented Dec 19, 2025

how did you fix this without updating any markers

@arkodg
Copy link
Contributor

arkodg commented Dec 19, 2025

@Aditya7880900936
Copy link
Contributor Author

Thanks for the pointer!
I’ve updated the kubebuilder printcolumn annotations in envoypatchpolicy_types.go to reference status.ancestors[].conditions per Gateway API conventions and regenerated the CRDs.
Please let me know if anything else needs adjustment.

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.59%. Comparing base (c1931a6) to head (2dec95f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7776      +/-   ##
==========================================
- Coverage   72.61%   72.59%   -0.02%     
==========================================
  Files         235      235              
  Lines       34876    34876              
==========================================
- Hits        25325    25319       -6     
- Misses       7745     7748       +3     
- Partials     1806     1809       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain
Copy link
Member

zirain commented Dec 19, 2025

please run make -k gen-check locally, and commit the changes.

@Aditya7880900936
Copy link
Contributor Author

I’ve run make -k gen-check locally and committed the updated helm test outputs.
Thanks!

@zirain zirain force-pushed the fix-envoypatchpolicy-printer-columns branch from ae710b9 to ed5ef5f Compare December 19, 2025 05:49
@Aditya7880900936
Copy link
Contributor Author

The remaining CI failures are from coverage-test.
This PR only updates CRD annotations and regenerated manifests, with no executable Go logic changes, so no additional coverage is produced.

Please let me know if you’d prefer:

skipping/overriding coverage for this PR, or

any specific test adjustments you’d like me to make.

@Aditya7880900936
Copy link
Contributor Author

Friendly ping — happy to help unblock if anything else is needed.

@Aditya7880900936
Copy link
Contributor Author

Thanks for the reviews and approvals!
The remaining CI failures are coverage-related and expected for this CRD-only change.
Happy to let maintainers decide the best way to proceed.

@Aditya7880900936
Copy link
Contributor Author

Hi @zirain ,

The PR has approvals now. The only remaining CI failures are coverage tests, which appear expected for this CRD-only change.

Please let me know if you’re okay to merge as-is, or if you’d like me to make any changes before merge.

@zirain zirain force-pushed the fix-envoypatchpolicy-printer-columns branch from 80535db to 9ba0c24 Compare December 23, 2025 07:05
@Aditya7880900936
Copy link
Contributor Author

Thanks everyone for the reviews and help!

@zirain
Copy link
Member

zirain commented Dec 24, 2025

/retest

@Aditya7880900936
Copy link
Contributor Author

Friendly ping @zirain — whenever you’re back online, please take a look.
Happy to help if anything else is needed. Thanks!

@Aditya7880900936
Copy link
Contributor Author

Hi @zirain ,
I checked the failing e2e jobs.

They fail in ZoneAwareRouting / BackendTrafficPolicy tests, which don’t appear related to this PR (CRD printer column metadata only).
The failure happens late in the suite and looks consistent with known e2e flakiness.

I’ve updated the branch to latest main.
Happy to re-run CI or dig further if needed.

@Aditya7880900936
Copy link
Contributor Author

Hi @zirain,

I’ve updated the branch to the latest main.

The remaining CI failures are in e2e-related jobs (ZoneAwareRouting / BackendTrafficPolicy) and don’t appear related to this change, which only updates CRD printer column metadata. The failures occur late in the suite and look consistent with known e2e flakiness.

All reviews are approved. Would you mind re-running the failing jobs or overriding CI if you’re comfortable?

Happy to investigate further if you think there’s any possible linkage I’m missing.
Thanks!

@arkodg arkodg merged commit 61727c0 into envoyproxy:main Dec 26, 2025
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EnvoyPatchPolicy CRD printer column references non-existent field, STATUS column empty in kubectl get

5 participants