-
Notifications
You must be signed in to change notification settings - Fork 620
fix(crd): correct EnvoyPatchPolicy printer columns #7776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(crd): correct EnvoyPatchPolicy printer columns #7776
Conversation
chaima-belhedi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanx for taking care of this @Aditya7880900936
|
Thanks a lot for the review and approval! Appreciate your time and guidance @chaima-belhedi |
|
how did you fix this without updating any markers |
|
Thanks for the pointer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7776 +/- ##
==========================================
- Coverage 72.61% 72.59% -0.02%
==========================================
Files 235 235
Lines 34876 34876
==========================================
- Hits 25325 25319 -6
- Misses 7745 7748 +3
- Partials 1806 1809 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
please run |
|
I’ve run make -k gen-check locally and committed the updated helm test outputs. |
ae710b9 to
ed5ef5f
Compare
|
The remaining CI failures are from coverage-test. Please let me know if you’d prefer: skipping/overriding coverage for this PR, or any specific test adjustments you’d like me to make. |
|
Friendly ping — happy to help unblock if anything else is needed. |
|
Thanks for the reviews and approvals! |
|
Hi @zirain , The PR has approvals now. The only remaining CI failures are coverage tests, which appear expected for this CRD-only change. Please let me know if you’re okay to merge as-is, or if you’d like me to make any changes before merge. |
Signed-off-by: Aditya7880900936 <[email protected]>
Signed-off-by: Aditya7880900936 <[email protected]>
Signed-off-by: Aditya7880900936 <[email protected]>
80535db to
9ba0c24
Compare
|
Thanks everyone for the reviews and help! |
|
/retest |
|
Friendly ping @zirain — whenever you’re back online, please take a look. |
|
Hi @zirain , They fail in ZoneAwareRouting / BackendTrafficPolicy tests, which don’t appear related to this PR (CRD printer column metadata only). I’ve updated the branch to latest main. |
|
Hi @zirain, I’ve updated the branch to the latest main. The remaining CI failures are in e2e-related jobs (ZoneAwareRouting / BackendTrafficPolicy) and don’t appear related to this change, which only updates CRD printer column metadata. The failures occur late in the suite and look consistent with known e2e flakiness. All reviews are approved. Would you mind re-running the failing jobs or overriding CI if you’re comfortable? Happy to investigate further if you think there’s any possible linkage I’m missing. |
What type of PR is this?
fix(crd): correct EnvoyPatchPolicy printer columns
What this PR does / why we need it:
This PR fixes the
additionalPrinterColumnsconfiguration for theEnvoyPatchPolicy CRD.
Previously, the STATUS column was empty because the printer column
referenced a non-existent field under
.status.conditions.EnvoyPatchPolicy follows Gateway API conventions and stores conditions
under
.status.ancestors[].conditions.This change updates the printer columns to reference condition
statusunder
.status.ancestors[].conditions, sokubectl get envoypatchpoliciescorrectly shows Accepted and Programmedstates.
Which issue(s) this PR fixes:
Fixes #7745
Release Notes: No