Skip to content

Commit 8c986ff

Browse files
authored
build: bake node v18.12.1 Appveyor image (electron#37250)
* chore: bake a new AppVeyor image * build: use image e-111.0.5560.0-4 * build: remove nodejs-lts * build: use new baked image
1 parent 71944f2 commit 8c986ff

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

appveyor-bake.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
version: 1.0.{build}
88
build_cloud: electronhq-16-core
9-
image: e-111.0.5560.0-2
9+
image: e-111.0.5560.0-node18
1010
environment:
1111
GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
1212
ELECTRON_OUT_DIR: Default

appveyor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929

3030
version: 1.0.{build}
3131
build_cloud: electronhq-16-core
32-
image: e-111.0.5560.0-2
32+
image: e-111.0.5560.0-node18
3333
environment:
3434
GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
3535
ELECTRON_OUT_DIR: Default

script/prepare-appveyor.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ const ROLLER_BRANCH_PATTERN = /^roller\/chromium$/;
1414

1515
const DEFAULT_BUILD_CLOUD_ID = '1598';
1616
const DEFAULT_BUILD_CLOUD = 'electronhq-16-core';
17-
const DEFAULT_BAKE_BASE_IMAGE = 'e-111.0.5560.0-2';
18-
const DEFAULT_BUILD_IMAGE = 'e-111.0.5560.0-2';
17+
const DEFAULT_BAKE_BASE_IMAGE = 'e-111.0.5560.0-node18';
18+
const DEFAULT_BUILD_IMAGE = 'e-111.0.5560.0-node18';
1919

2020
const appveyorBakeJob = 'electron-bake-image';
2121
const appVeyorJobs = {

script/setup-win-for-dev.bat

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ REM Install Windows SDK
5656
choco install windows-sdk-10-version-2104-all
5757

5858
REM Install nodejs python git and yarn needed dependencies
59-
choco install -y nodejs-lts python2 git yarn
59+
choco install -y --force nodejs@v18.12.1
60+
choco install -y python2 git yarn
6061
choco install python --version 3.7.9
6162
call C:\ProgramData\chocolatey\bin\RefreshEnv.cmd
6263
SET PATH=C:\Python27\;C:\Python27\Scripts;C:\Python39\;C:\Python39\Scripts;%PATH%

0 commit comments

Comments
 (0)