Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: editorconfig-checker/editorconfig-checker
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: editorconfig-checker/editorconfig-checker
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: golangci-lint
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 16 commits
  • 11 files changed
  • 1 contributor

Commits on Mar 6, 2025

  1. ci: run golangci-lint

    @klaernie
    klaernie committed Mar 6, 2025
    Configuration menu
    Copy the full SHA
    401ad8e View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2025

  1. fix(lint): errors should be printed as strings 

    Since this was done with the go1.24 migration differently, I just
remembered that printing the errors as strings should be the simpler
approach.
    @klaernie
    klaernie committed Mar 7, 2025
    Configuration menu
    Copy the full SHA
    6abb84c View commit details
    Browse the repository at this point in the history

  2. fix(lint): declare that we intentionally ignore this returned error

    @klaernie
    klaernie committed Mar 7, 2025
    Configuration menu
    Copy the full SHA
    ca1b230 View commit details
    Browse the repository at this point in the history

  3. ci: enable all golangci-lint linters by default

    @klaernie
    klaernie committed Mar 7, 2025
    Configuration menu
    Copy the full SHA
    3ec921d View commit details
    Browse the repository at this point in the history

  4. ci: disable the deprecated linters

    @klaernie
    klaernie committed Mar 7, 2025
    Configuration menu
    Copy the full SHA
    d848e2d View commit details
    Browse the repository at this point in the history

  5. ci: use a more sensible starting point for golangci-lint

    @klaernie
    klaernie committed Mar 7, 2025
    Configuration menu
    Copy the full SHA
    b29449f View commit details
    Browse the repository at this point in the history

  6. ci: ignore a misspelling, since it is a username, not an actual word

    @klaernie
    klaernie committed Mar 7, 2025
    Configuration menu
    Copy the full SHA
    bf96257 View commit details
    Browse the repository at this point in the history

  7. fix(lint): keep name consistent with the other functions

    @klaernie
    klaernie committed Mar 7, 2025
    Configuration menu
    Copy the full SHA
    714107c View commit details
    Browse the repository at this point in the history

  8. fix(lint): rename variable to camelCase

    @klaernie
    klaernie committed Mar 7, 2025
    Configuration menu
    Copy the full SHA
    ba0e539 View commit details
    Browse the repository at this point in the history

  9. fix(lint): discovered more typos

    @klaernie
    klaernie committed Mar 7, 2025
    Configuration menu
    Copy the full SHA
    3f08cd1 View commit details
    Browse the repository at this point in the history

  10. fix(lint): arguments of type testing.T should always be first

    @klaernie
    klaernie committed Mar 7, 2025
    Configuration menu
    Copy the full SHA
    1f035f3 View commit details
    Browse the repository at this point in the history

  11. fix(lint): listAllCharsets() is a helper function

    @klaernie
    klaernie committed Mar 7, 2025
    Configuration menu
    Copy the full SHA
    e6262fe View commit details
    Browse the repository at this point in the history

  12. fix(lint): func GetContentTypeBytes() doesn't need the config, so rem… 

    …ove the arg

then remove the now unused variables and arguments from the functions
earlier in the callchain
    @klaernie
    klaernie committed Mar 7, 2025
    Configuration menu
    Copy the full SHA
    0a3644b View commit details
    Browse the repository at this point in the history

  13. fix(lint): remove initialization to the zero value

    @klaernie
    klaernie committed Mar 7, 2025
    Configuration menu
    Copy the full SHA
    9d93d5d View commit details
    Browse the repository at this point in the history

  14. fix(lint): infer types

    @klaernie
    klaernie committed Mar 7, 2025
    Configuration menu
    Copy the full SHA
    c37482a View commit details
    Browse the repository at this point in the history

  15. ci: switch from gci to goimports

    @klaernie
    klaernie committed Mar 7, 2025
    Configuration menu
    Copy the full SHA
    98b6d2b View commit details
    Browse the repository at this point in the history
Loading