-
Notifications
You must be signed in to change notification settings - Fork 445
Open
Labels
type:bugSomething isn't workingSomething isn't working
Description
What went wrong?
After successfully starting buildkitd entrypoint starts trying to kill every other process with SIGKILL, which does not do anything with usual image, but can be fatal if there's other processes right next to builkdkitd
What should have happened?
Entrypoint should have waited for buildkitd to exit.
What earthly version?
I hit that with earthly/satellite:v0.8.15
Buildkit Logs
No response
Other Helpful Information
I think this bug was introduced here
1406b9f
Before
if ! kill -0 "$execpid" >/dev/null 2>&1; then
echo "Error: buildkit process has exited"
exit 1
fiIf sending signal zero to $execpid fails, then it logs error and exit with 1
After
if ! kill -0 "$execpid" >/dev/null 2>&1; then
wait "$execpid"
code="$?"
if [ "$code" != "0" ]; then
echo "Error: buildkit process has exited with code $code"
fi
exit "$code"
fiIf sending signal zero to $execpid fails, then it start waiting for it to exit!
And after 1f97c43, if sending signal zero did not fail, it will fall through to sending SIGKILL to every child of PID 1.
Metadata
Metadata
Assignees
Labels
type:bugSomething isn't workingSomething isn't working