Skip to content

Conversation

@geemus
Copy link
Contributor

@geemus geemus commented Oct 29, 2024

fixes #863

@geemus
Copy link
Contributor Author

geemus commented Oct 30, 2024

Seems like this is still failing to fix the test case in #863, need to think/dig a bit more.

@geemus geemus merged commit 730e63a into master Oct 30, 2024
5 checks passed
@geemus geemus deleted the encoding-aware-query-parse branch October 30, 2024 20:17
@geemus
Copy link
Contributor Author

geemus commented Oct 30, 2024

Also commented on #863, but will duplicate here to keep info together:

Ok, I think I was overthinking/overdoing it. I've simplified #869 so that instead of trying to do escaping, it just splits based on &/; and :. That should get the original goal (normalizing so that if you use a hash to define the mock but a string to call it, or vice versa, it still matches). I think I was thinking about the real case (where escaping comes into play). Especially since this is all internal for the sake of matching stubs, the encoding wasn't really gaining us much even if it was working (and it wasn't working).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Since 1.0.0, an escaped non-utf8 query parameter raises with webmock

3 participants