Deprecate omit_default_port option, add include_default_port option #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
geemus
commented
Oct 9, 2024
- Port being added to URL can be forced by using include_default_port option
- Simplifies some of the port addition code
- Break out logic to determine if a default port is logic into its own method
- Tests basic cases of scheme+port combinations
- Port being added to URL can be forced by using include_default_port option - Simplifies some of the port addition code - Break out logic to determine if a default port is logic into its own method - Tests basic cases of scheme+port combinations
29cd7d3 to
154d9c7
Compare
geemus
added a commit
to voxik/excon
that referenced
this pull request
Oct 29, 2024
…xcon#856) * Deprecate omit_default_port option, add include_default_port option - Port being added to URL can be forced by using include_default_port option - Simplifies some of the port addition code - Break out logic to determine if a default port is logic into its own method - Tests basic cases of scheme+port combinations * allow omit_default_port for better backwards compatibility * add a deprecation warning * add deprecation warning when setting omit_default_port to non-default value --------- Co-authored-by: Matt Gauger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.