[chore][cmd/telemetrygen] run make modernize (open-telemetry#43224)

paulojmdias · etserend · commit 4861931e83e5 · 2025-10-08T17:23:19.000-05:00
#### Description Run the `make modernize` tool. https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
diff --git a/cmd/telemetrygen/pkg/metrics/worker.go b/cmd/telemetrygen/pkg/metrics/worker.go
@@ -183,7 +183,7 @@ func (w worker) simulateMetrics(res *resource.Resource, exporter sdkmetric.Expor
 
 			// Add random values to the histogram
 			count := 10 + w.rand.IntN(20) // Random count between 10-30
-			for j := 0; j < count; j++ {
+			for range count {
 				value := float64(w.rand.IntN(1000))
 				hist.Update(value)
 			}
diff --git a/cmd/telemetrygen/pkg/metrics/worker_test.go b/cmd/telemetrygen/pkg/metrics/worker_test.go
@@ -245,7 +245,7 @@ func TestSumNoTelemetryAttrs(t *testing.T) {
 	require.Len(t, m.rms, qty)
 
 	rms := m.rms
-	for i := 0; i < qty; i++ {
+	for i := range qty {
 		ms := rms[i].ScopeMetrics[0].Metrics[0]
 		assert.Equal(t, "test", ms.Name)
 		// @note update when telemetrygen allow other metric types
@@ -273,7 +273,7 @@ func TestGaugeNoTelemetryAttrs(t *testing.T) {
 	require.Len(t, m.rms, qty)
 
 	rms := m.rms
-	for i := 0; i < qty; i++ {
+	for i := range qty {
 		ms := rms[i].ScopeMetrics[0].Metrics[0]
 		assert.Equal(t, "test", ms.Name)
 		// @note update when telemetrygen allow other metric types
@@ -301,7 +301,7 @@ func TestSumSingleTelemetryAttr(t *testing.T) {
 	require.Len(t, m.rms, qty)
 
 	rms := m.rms
-	for i := 0; i < qty; i++ {
+	for i := range qty {
 		ms := rms[i].ScopeMetrics[0].Metrics[0]
 		assert.Equal(t, "test", ms.Name)
 		// @note update when telemetrygen allow other metric types
@@ -331,7 +331,7 @@ func TestGaugeSingleTelemetryAttr(t *testing.T) {
 	require.Len(t, m.rms, qty)
 
 	rms := m.rms
-	for i := 0; i < qty; i++ {
+	for i := range qty {
 		ms := rms[i].ScopeMetrics[0].Metrics[0]
 		assert.Equal(t, "test", ms.Name)
 		// @note update when telemetrygen allow other metric types
@@ -362,7 +362,7 @@ func TestSumMultipleTelemetryAttr(t *testing.T) {
 
 	rms := m.rms
 	var actualValue attribute.Value
-	for i := 0; i < qty; i++ {
+	for i := range qty {
 		ms := rms[i].ScopeMetrics[0].Metrics[0]
 		// @note update when telemetrygen allow other metric types
 		attr := ms.Data.(metricdata.Sum[int64]).DataPoints[0].Attributes
@@ -398,7 +398,7 @@ func TestGaugeMultipleTelemetryAttr(t *testing.T) {
 
 	rms := m.rms
 	var actualValue attribute.Value
-	for i := 0; i < qty; i++ {
+	for i := range qty {
 		ms := rms[i].ScopeMetrics[0].Metrics[0]
 		// @note update when telemetrygen allow other metric types
 		attr := ms.Data.(metricdata.Gauge[int64]).DataPoints[0].Attributes
@@ -636,7 +636,7 @@ func TestUniqueSumTimeseries(t *testing.T) {
 	rms := m.rms
 	var actualValue attribute.Value
 	var exist bool
-	for i := 0; i < qty; i++ {
+	for i := range qty {
 		ms := rms[i].ScopeMetrics[0].Metrics[0]
 		// @note update when telemetrygen allow other metric types
 		attr := ms.Data.(metricdata.Sum[int64]).DataPoints[0].Attributes
diff --git a/cmd/telemetrygen/pkg/traces/traces_test.go b/cmd/telemetrygen/pkg/traces/traces_test.go
@@ -531,7 +531,7 @@ func TestSpanContextsBufferLimit(t *testing.T) {
 	}
 
 	// Add more span contexts than the buffer limit
-	for i := 0; i < 1200; i++ {
+	for i := range 1200 {
 		traceID, _ := trace.TraceIDFromHex(fmt.Sprintf("%032d", i))
 		spanID, _ := trace.SpanIDFromHex(fmt.Sprintf("%016d", i))
 		spanCtx := trace.NewSpanContext(trace.SpanContextConfig{

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ func (w worker) simulateMetrics(res *resource.Resource, exporter sdkmetric.Expor`
`183`	`183`
`184`	`184`	`// Add random values to the histogram`
`185`	`185`	`count := 10 + w.rand.IntN(20) // Random count between 10-30`
`186`		`- for j := 0; j < count; j++ {`
	`186`	`+ for range count {`
`187`	`187`	`value := float64(w.rand.IntN(1000))`
`188`	`188`	`hist.Update(value)`
`189`	`189`	`}`
Original file line number	Diff line number	Diff line change
`@@ -531,7 +531,7 @@ func TestSpanContextsBufferLimit(t *testing.T) {`
`531`	`531`	`}`
`532`	`532`
`533`	`533`	`// Add more span contexts than the buffer limit`
`534`		`- for i := 0; i < 1200; i++ {`
	`534`	`+ for i := range 1200 {`
`535`	`535`	`traceID, _ := trace.TraceIDFromHex(fmt.Sprintf("%032d", i))`
`536`	`536`	`spanID, _ := trace.SpanIDFromHex(fmt.Sprintf("%016d", i))`
`537`	`537`	`spanCtx := trace.NewSpanContext(trace.SpanContextConfig{`