Skip to content

Commit 388e7e7

Browse files
Copilotnagilson
andcommitted
Improve agent instructions with specific timeouts and commands
Co-authored-by: nagilson <[email protected]>
1 parent 7e654f8 commit 388e7e7

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

.github/agents/fixcompletions.instructions.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ First, ensure the repository is built with the latest changes:
2727
./build.sh
2828
```
2929

30-
This may take 5-10 minutes. Use a timeout of at least 600 seconds (10 minutes) for the build command.
30+
This may take 5-10 minutes. Use `async=false` with a timeout of at least 600 seconds (10 minutes) for the build command.
3131

3232
### Step 2: Run the Completion Tests
3333

@@ -38,7 +38,7 @@ Run the specific completion snapshot tests to generate the new `.received.` file
3838
./.dotnet/dotnet test test/dotnet.Tests/dotnet.Tests.csproj --filter "FullyQualifiedName~VerifyCompletions"
3939
```
4040

41-
This will run the `VerifyCompletions` test which generates completion snapshots for all supported shells.
41+
This will run the `VerifyCompletions` test which generates completion snapshots for all supported shells. Allow at least 300 seconds (5 minutes) for this command.
4242

4343
**Important**: The tests will likely FAIL if there are differences between current and expected snapshots. This is expected and correct behavior - don't be alarmed by test failures.
4444

.github/agents/updatexlf.instructions.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,19 @@ You are an expert at managing localization files in .NET projects. When invoked:
2020

2121
1. **Check the current state**: First, identify if there are any .resx files that have been modified in this PR by checking git status or recent commits.
2222

23-
2. **Run the UpdateXlf target**: Execute the MSBuild UpdateXlf target to update all XLF files:
23+
2. **Run the UpdateXlf target**: The repository is built on a Linux environment, so use the appropriate build script:
24+
25+
First, try running just the UpdateXlf target (faster):
2426
```bash
25-
msbuild /t:UpdateXlf
27+
./build.sh /t:UpdateXlf
2628
```
2729

2830
If that doesn't work or if the target is not found, perform a full build which will also update XLF files:
2931
```bash
3032
./build.sh
3133
```
34+
35+
The build may take 5-10 minutes. Use `async=false` with a timeout of at least 600 seconds (10 minutes).
3236

3337
3. **Verify the changes**: Check which XLF files were modified:
3438
```bash
@@ -56,7 +60,7 @@ You are an expert at managing localization files in .NET projects. When invoked:
5660

5761
When a user comments `/updatexlf`:
5862

59-
1. Run: `msbuild /t:UpdateXlf` (or `./build.sh` if needed)
63+
1. Run: `./build.sh /t:UpdateXlf` (with 600s timeout) or `./build.sh` if needed
6064
2. Check: `git status` and `git diff` to see what changed
6165
3. Verify: Look at 1-2 XLF files to ensure they have proper state attributes
6266
4. Commit: Use `report_progress` with message "Update XLF translation files"

0 commit comments

Comments
 (0)