Skip to content

Fix roslyn to build with boostrapped build #12500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2021
Merged

Fix roslyn to build with boostrapped build #12500

merged 1 commit into from
Oct 25, 2021

Conversation

dseefeld
Copy link

@dseefeld dseefeld commented Oct 23, 2021 •
edited by MichaelSimons
Loading

Switch roslyn build to build with .slnf file to exclude projects with <Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">. This enables roslyn to be built with a bootstrapped source-built SDK.

Related to dotnet/roslyn#57342

@dseefeld dseefeld requested a review from a team as a code owner October 23, 2021 01:42
@dseefeld dseefeld marked this pull request as draft October 23, 2021 02:57
@dagood
Copy link
Member

dagood commented Oct 23, 2021

Potential alternative: create a stub Microsoft.NET.Sdk.WindowsDesktop and use the SourceBuiltSdkResolver to redirect the projects to it. This could be lower-maintenance than a solution filter.