Fixed #27222 -- Refreshed model field values assigned expressions on save(). #19285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

charettes wants to merge 2 commits into django:main from charettes:ticket-27222

+334 −120

Member

charettes commented Mar 19, 2025

Trac ticket number

charettes force-pushed the ticket-27222 branch from 1f1340f to ab9c65d Compare

March 19, 2025 06:31

charettes commented

View reviewed changes

tests/basic/tests.py Outdated Show resolved Hide resolved

charettes force-pushed the ticket-27222 branch from ab9c65d to cb4dea7 Compare

March 22, 2025 02:40

charettes commented

View reviewed changes

django/db/backends/oracle/operations.py Outdated Show resolved Hide resolved

charettes force-pushed the ticket-27222 branch from cb4dea7 to d33499b Compare

March 22, 2025 03:03

charettes commented

View reviewed changes

django/db/models/base.py Outdated Show resolved Hide resolved

charettes commented

View reviewed changes

django/db/models/base.py Outdated Show resolved Hide resolved

charettes commented

View reviewed changes

docs/releases/6.0.txt Outdated Show resolved Hide resolved

charettes force-pushed the ticket-27222 branch from d33499b to c5f4a49 Compare

March 22, 2025 03:14

charettes commented

View reviewed changes

django/db/models/sql/compiler.py Outdated Show resolved Hide resolved

charettes commented

View reviewed changes

django/db/models/sql/compiler.py Outdated Show resolved Hide resolved

charettes commented

View reviewed changes

django/db/models/sql/compiler.py Outdated Show resolved Hide resolved

charettes force-pushed the ticket-27222 branch from c5f4a49 to 8e35b4b Compare

March 22, 2025 04:02

charettes commented

View reviewed changes

docs/releases/6.0.txt Outdated Show resolved Hide resolved

charettes force-pushed the ticket-27222 branch from 8e35b4b to 0f711f0 Compare

March 22, 2025 04:44

charettes marked this pull request as ready for review

March 22, 2025 04:48

charettes commented

View reviewed changes

django/db/models/base.py Outdated Show resolved Hide resolved

charettes mentioned this pull request

Fixed #32406 -- Demonstration of how update and bulk_update could take advantage of returning rows. #19298

Draft

charettes force-pushed the ticket-27222 branch from 0f711f0 to a03ebf9 Compare

April 15, 2025 04:56

charettes commented

View reviewed changes

django/db/models/base.py Outdated Show resolved Hide resolved

charettes force-pushed the ticket-27222 branch from a03ebf9 to caa28d5 Compare

April 24, 2025 22:12

charettes force-pushed the ticket-27222 branch from caa28d5 to 0f97dde Compare

May 6, 2025 13:12

charettes commented

View reviewed changes

django/db/models/fields/__init__.py Outdated Show resolved Hide resolved

charettes force-pushed the ticket-27222 branch from 0f97dde to 9aad58e Compare

May 6, 2025 16:09

Member Author

charettes commented May 6, 2025

The unveiled failures are related to this ticket

TL;DR the documented pattern for copying model instances breaks when some fields are deferred on the original instance.

This poses a problem with this patch as it marks any field assigned a database expression at save time, db_default included, as deferred instead of leaving a dangling expression assigned (a DatabaseDefault instance in the case of db_default).