Skip to content

allow configuring forward behaviours #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 19, 2025
Merged

allow configuring forward behaviours #102

merged 5 commits into from
Sep 19, 2025

Conversation

@dhth
Copy link
Owner

@dhth dhth commented Sep 19, 2025

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @dhth, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the configurability of the forward command by introducing a comprehensive set of environment variables to control its operational behaviors. It centralizes the parsing and validation of these environment variables into dedicated helper functions, leading to a more robust and maintainable configuration system. The changes allow users to fine-tune various aspects of the forwarder, such as Kafka fetching, upload workers, and timeout settings, without modifying the codebase, thereby improving its adaptability to different deployment environments and performance requirements.

Highlights

  • Centralized Environment Variable Parsing: Introduced a new file, internal/cmd/env.go, containing helper functions (getBoolEnvVar, getStringEnvVar, getConstrainedStringEnvVar, getUint16EnvVar) for robust parsing and validation of environment variables, ensuring consistent handling across the application.
  • Expanded Forwarder Configuration: The forward command now supports a wide array of configurable behaviors via environment variables, allowing users to fine-tune parameters such as Kafka fetch batch sizes, number of upload workers, various timeouts (shutdown, poll fetch, upload), and polling/worker sleep intervals.
  • Refactored Configuration Loading: All forwarder-specific environment variables are now loaded and validated through a new getBehaviorsFromEnv function within internal/cmd/forward.go, which aggregates any parsing or validation errors, significantly improving modularity and error handling.
  • Enhanced Behaviours Struct: The internal/forwarder/behaviours.go struct has been substantially extended to encapsulate all the new configurable parameters, providing a single, comprehensive source of truth for forwarder operational settings, and its Display() method was updated to reflect these changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 19, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces configurability for various forwarder behaviors via environment variables, which is a great enhancement. The changes are well-structured, with new helper functions for parsing environment variables in internal/cmd/env.go and a clean refactoring of internal/cmd/forward.go. My review includes a few suggestions to improve logging and consistency.

@dhth
Copy link
Owner Author

dhth commented Sep 19, 2025

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 19, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces configurability for the forwarder's behaviors via environment variables, which is a great enhancement. The changes are well-structured, with new helper functions for parsing environment variables and a clear separation of concerns. My review includes suggestions to improve maintainability by reducing code duplication, enhance logging for better observability, and fix a potential issue with context propagation during shutdown to ensure graceful termination. Overall, this is a solid contribution.

@dhth
Copy link
Owner Author

dhth commented Sep 19, 2025

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 19, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great step forward in making the forwarder's behavior configurable through environment variables. The introduction of helper functions in internal/cmd/env.go for parsing and validating these variables is a clean approach that improves code organization and readability. The refactoring in internal/cmd/forward.go to centralize environment variable handling in getBehaviorsFromEnv is also a significant improvement. I have a couple of suggestions to enhance structured logging and improve the consistency of the new configuration options.

@dhth dhth merged commit 3577199 into main Sep 19, 2025
15 checks passed
@dhth dhth deleted the allow-configuring-forward-behaviours branch September 19, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhth