Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jordansissel/fpm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: dezgeg/fpm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on May 30, 2018

  1. Fix creating packages with read-only directories 

    Creating a package of the following directory hierarchy would crash:

mkdir -p dir
touch dir/foo
chmod 555 dir
fpm --input-type dir --output-type rpm --name test dir

This is due to as part of the copying, fpm would first create the
directory 'dir' with 0555 permissions in the staging directory, and then
copy 'dir/foo' inside that directory. Which would then crash because
the directory has no write permission.

To fix this, don't try to set the permissions of directories on the fly,
only set them at the very end. Also FileUtils.rm_r doesn't get rid of
such directories, so switch to rm_rf.

Fixes #807.
    @dezgeg
    dezgeg committed May 30, 2018
    Configuration menu
    Copy the full SHA
    c126785 View commit details
    Browse the repository at this point in the history
Loading