Broaden exclusion criteria for “as” method in RequestManagerGenerator.

sjudd · sjudd · commit d94e99453734 · 2017-05-26T08:17:45.000-07:00
We’re being overly specific. At least for now, there’s only one “as” method so we can exclude it based on the name alone. Addresses bumptech#1971.
diff --git a/annotation/compiler/src/main/java/com/bumptech/glide/annotation/compiler/RequestManagerGenerator.java b/annotation/compiler/src/main/java/com/bumptech/glide/annotation/compiler/RequestManagerGenerator.java
@@ -170,10 +170,7 @@ private List<MethodSpec> generateRequestManagerMethodOverrides() {
           @Override
           public boolean apply(ExecutableElement input) {
             // Skip the <T> as(Class<T>) method.
-            return !input.getSimpleName().toString().equals("as")
-                || input.getParameters().size() != 1
-                || !processingEnv.getTypeUtils().isAssignable(
-                    input.getParameters().get(0).asType(), rawClassType);
+            return !input.getSimpleName().toString().equals("as");
           }
         })
         .transform(new Function<ExecutableElement, MethodSpec>() {
