Tests: Fix ContainerServer.New tests when crio is installed

andreaskaris · andreaskaris · commit aad475ff99ae · 2025-08-07T14:42:41.000+02:00
Skip InternalRepair by simulating a clean shutdown. Signed-off-by: Andreas Karis <ak.karis@gmail.com> Reported-at: #9389
diff --git a/internal/lib/container_server_test.go b/internal/lib/container_server_test.go
@@ -38,6 +38,11 @@ var _ = t.Describe("ContainerServer", func() {
 			config.HooksDir = []string{}
 			// so we have permission to make a directory within it
 			config.ContainerAttachSocketDir = t.MustTempDir("crio")
+			// Simulate a clean shutdown. Otherwise, when running tests as root on
+			// a system where cri-o is already installed, we hit non-mocked functions
+			// in lib.New internal/lib/container_server.go in if condition
+			// `if config.InternalRepair && ShutdownWasUnclean(config)`.
+			config.CleanShutdownFile = t.MustTempFile("clean.shutdown")
 
 			// Specify mocks
 			gomock.InOrder(
diff --git a/internal/lib/suite_test.go b/internal/lib/suite_test.go
@@ -145,6 +145,11 @@ func beforeEach() {
 	config.HooksDir = []string{}
 	// so we have permission to make a directory within it
 	config.ContainerAttachSocketDir = t.MustTempDir("crio")
+	// Simulate a clean shutdown. Otherwise, when running tests as root on
+	// a system where cri-o is already installed, we hit non-mocked functions
+	// in lib.New internal/lib/container_server.go in if condition
+	// `if config.InternalRepair && ShutdownWasUnclean(config)`.
+	config.CleanShutdownFile = t.MustTempFile("clean.shutdown")
 
 	gomock.InOrder(
 		libMock.EXPECT().GetStore().Return(storeMock, nil),
