[Robots.txt] Add units test based on examples in RFC 9309 #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for all examples provided in RFC 9309. For the examples of paths containing percent-encoded characters the unit tests of Google's RFC reference parser and the errata were consulted:
/foo/bar/\u30C4resp./foo/bar/%E3%83%84- see errata/foo/bar?baz=https://foo.barand/foo/bar?baz=https%3A%2F%2Ffoo.barare matched "as is" without decoding or encoding also in the unit tests of the reference parser. See also the discussion of #309 for crawler-commons' BasicURLNormalizer./foo/bar/%62%61%7Ain the robots.txt matches/foo/bar/baz- it's a minor improvement of SimpleRobotRulesParser over the reference parser