feat(#132): Add attempts flag for AI refactoring attempts configuration (#134)

volodya-lombrozo · web-flow · commit 5be27cbac485 · 2025-10-23T15:24:58.000+03:00
diff --git a/cmd/root.go b/cmd/root.go
@@ -38,6 +38,7 @@ func NewRootCmd(out, _ io.Writer) *cobra.Command {
 	root.PersistentFlags().StringVar(&params.Soutput, "stats-output", "stats", "Output path for statistics")
 	root.PersistentFlags().BoolVar(&params.Colorless, "no-colors", false, "Disable colored output")
 	root.PersistentFlags().StringVarP(&params.Model, "model", "m", "", "Model to use (if supported by the AI provider)")
+	root.PersistentFlags().IntVar(&params.Attempts, "attempts", 3, "How many attempts the AI has to make a valid refactoring")
 	root.AddCommand(
 		newRefactorCmd(&params),
 		newStartCmd(),
diff --git a/internal/client/params.go b/internal/client/params.go
@@ -19,6 +19,7 @@ type Params struct {
 	Checks      []string
 	Colorless   bool
 	Model       string
+	Attempts    int
 }
 
 // NewMockParams creates a new Params object with mock settings.
@@ -39,5 +40,6 @@ func NewMockParams() *Params {
 		Checks:      []string{"mvn clean test"},
 		Colorless:   false,
 		Model:       "gpt-3.5-turbo",
+		Attempts:    3,
 	}
 }
diff --git a/internal/client/refrax_client.go b/internal/client/refrax_client.go
@@ -160,7 +160,7 @@ func (c *RefraxClient) Refactor(proj domain.Project) (domain.Project, error) {
 	if err != nil {
 		return nil, fmt.Errorf("failed to find free port for facilitator: %w", err)
 	}
-	fclttor := facilitator.NewFacilitator(facilitatorBrain, ctc, fxr, rvwr, facilitatorPort, c.params.Colorless)
+	fclttor := facilitator.NewFacilitator(facilitatorBrain, ctc, fxr, rvwr, facilitatorPort, c.params.Colorless, c.params.Attempts)
 	fclttor.Handler(countStats(facilitatorStats))
 
 	go func() {
diff --git a/internal/facilitator/agent.go b/internal/facilitator/agent.go
@@ -21,6 +21,7 @@ type agent struct {
 	fixer    domain.Fixer
 	reviewer domain.Reviewer
 	frounds  int
+	attempts int
 }
 
 type fix struct {
@@ -45,7 +46,14 @@ func (a *agent) Refactor(job *domain.Job) (*domain.Artifacts, error) {
 	}
 	diff := 0
 	result := make([]domain.Class, 0)
-	for diff < size {
+	attempts := a.attempts
+	if attempts <= 0 {
+		a.log.Info("Number of attempts less or equal zero (%d), skipping refactoring", attempts)
+	} else {
+		a.log.Info("Starting refactoring with max-size=%d and attempts=%d", size, attempts)
+	}
+	for diff < size && attempts > 0 {
+		a.log.Info("Refactoring attempt %d/%d, current diff %d/%d", a.attempts-attempts+1, a.attempts, diff, size)
 		c, err := a.criticizeAll(job.Classes, size)
 		if err != nil {
 			return nil, fmt.Errorf("failed to criticize classes: %w", err)
@@ -81,6 +89,7 @@ func (a *agent) Refactor(job *domain.Job) (*domain.Artifacts, error) {
 		if err != nil {
 			return nil, fmt.Errorf("failed to stabilize refactored classes: %w", err)
 		}
+		attempts--
 	}
 	res := &domain.Artifacts{
 		Descr:   &domain.Description{Text: "refactored classes"},
diff --git a/internal/facilitator/server.go b/internal/facilitator/server.go
@@ -20,7 +20,7 @@ type A2AFacilitator struct {
 }
 
 // NewFacilitator creates a new instance of Facilitator to manage communication between agents.
-func NewFacilitator(ai brain.Brain, critic domain.Critic, fixer domain.Fixer, reviewer domain.Reviewer, port int, colorless bool) *A2AFacilitator {
+func NewFacilitator(ai brain.Brain, critic domain.Critic, fixer domain.Fixer, reviewer domain.Reviewer, port int, colorless bool, attempts int) *A2AFacilitator {
 	logger := log.New("facilitator", log.Yellow, colorless)
 	logger.Debug("preparing server on port %d with ai provider %s", port, ai)
 	server := protocol.NewServer(agentCard(port), port)
@@ -35,6 +35,7 @@ func NewFacilitator(ai brain.Brain, critic domain.Critic, fixer domain.Fixer, re
 			fixer:    fixer,
 			reviewer: reviewer,
 			frounds:  3,
+			attempts: attempts,
 		},
 	}
 	server.MsgHandler(facilitator.think)

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ type Params struct {`
`19`	`19`	`Checks []string`
`20`	`20`	`Colorless bool`
`21`	`21`	`Model string`
	`22`	`+ Attempts int`
`22`	`23`	`}`
`23`	`24`
`24`	`25`	`// NewMockParams creates a new Params object with mock settings.`
`@@ -39,5 +40,6 @@ func NewMockParams() *Params {`
`39`	`40`	`Checks: []string{"mvn clean test"},`
`40`	`41`	`Colorless: false,`
`41`	`42`	`Model: "gpt-3.5-turbo",`
	`43`	`+ Attempts: 3,`
`42`	`44`	`}`
`43`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ func (c *RefraxClient) Refactor(proj domain.Project) (domain.Project, error) {`
`160`	`160`	`if err != nil {`
`161`	`161`	`return nil, fmt.Errorf("failed to find free port for facilitator: %w", err)`
`162`	`162`	`}`
`163`		`- fclttor := facilitator.NewFacilitator(facilitatorBrain, ctc, fxr, rvwr, facilitatorPort, c.params.Colorless)`
	`163`	`+ fclttor := facilitator.NewFacilitator(facilitatorBrain, ctc, fxr, rvwr, facilitatorPort, c.params.Colorless, c.params.Attempts)`
`164`	`164`	`fclttor.Handler(countStats(facilitatorStats))`
`165`	`165`
`166`	`166`	`go func() {`