This repository was archived by the owner on Feb 24, 2020. It is now read-only.
stage0: improve list --format behavior and flags #3403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
reviewed
Nov 23, 2016
| if err == nil { | ||
| return t, nil | ||
| } | ||
| if !os.IsNotExist(err) { |
Member
There was a problem hiding this comment.
Can you please retain the original exited-without-pid comment here?
This change reuses the `image list` flag parsing for `list`. It also makes `list` and `list --format=json` have more similar behavior in when the pod manifest is skipped. Fixes rkt#3402
65b3511 to
2698e6c
Compare
Member
Author
|
Comment addressed, the semaphore failure is the kvm rkt stop one. |
Member
|
Thanks, looks nice. I'm pretty much convinced that the kvm-stop failures are due to #3382, should we perhaps disable the test in the meanwhile to not impact other PRs? |
Member
Author
|
If we're going to only ignore it and it flakes/fails this badly, yeah. |
euank
added a commit
to euank/rktlet
that referenced
this pull request
Nov 28, 2016
See rkt/rkt#3403 This changes rktlet to re-use the type exported there and updates for the size type-change as well.
euank
added a commit
to euank/kubernetes
that referenced
this pull request
Jan 20, 2017
See rkt/rkt#3403 This changes rktlet to re-use the type exported there and updates for the size type-change as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reuses the
image listflag parsing forlist.It also makes
listandlist --format=jsonhave more similar behaviorin when the pod manifest is skipped.
Fixes #3402
I'd also like to add more tests since I wouldn't be surprised if the coverage is a bit low here.