-
Notifications
You must be signed in to change notification settings - Fork 881
docs/networking: minor clarification to DHCP type #3325
Conversation
|
I think the changes help a bit in the understanding the special nature of the |
Documentation/networking/overview.md
Outdated
| ### dhcp | ||
|
|
||
| DHCP type requires a daemon to be running on the host. | ||
| The DHCP type requires a special DHCP daemon, part of the [CNI DHCP plugin][cni-dhcp], to be running on the host. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could avoid a lot of confusion here if we stop calling this a DHCP daemon. While the name is technically correct, everybody expects this to mean "the DHCP service which manages all addresses in the subnet", while in our case it is just a middleman service.
Can we perhaps call it a DHCP (host) agent?
|
@venekamp thanks for the feedback! What you are describing above sounds like a DHCP proxy, but I don't think it is the case for the current plugin. This one should just register itself as a DHCP endpoint (client) and hand out the assigned network config via CNI semantics (paging @squeed just to confirm I'm not wrong here). If the above statement is correct, I think it is better described as a "DHCP (host) agent" more than a daemon or a proxy. |
|
Well, it's a dhcp client daemon. It's a bit more than a proxy; it also keeps the leases alive while the container is running. My suggested wording would be:
|
|
@lucab, @squeed My first understanding was that it was a fully operational DHCP server, then I thought it was a proxying client and now I understand it to be more than just relaying DHCP messages. I would try to clarify what this "thing" does and what it expects. My try would be:
You can omit the last sentence. At least I think this is why the plugin can renew leases and such things, while processes inside the container do no-longer have the capabilities to make changes to the interface. |
Make it explicit that the DHCP daemon being referred to is the one that's part of the special CNI DHCP plugin.
|
updated, ptal |
Documentation/networking/overview.md
Outdated
|
|
||
| The DHCP plugin binary can be executed in the daemon mode by launching it with `daemon` argument. | ||
| However the DHCP plugin is bundled in stage1.aci so this requires extracting the binary from it: | ||
| However in rkt the DHCP plugin is bundled in stage1.aci so this requires extracting the binary from it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, I think there should be a , after however.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack
|
I think it reads well. |
Documentation/networking/overview.md
Outdated
| ``` | ||
|
|
||
| For more information about DHCP plugin, see [CNI docs](https://github.com/appc/cni/blob/master/Documentation/dhcp.md). | ||
| For more information about DHCP plugin, see the [CNI docs][cni-dhcp]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... about [the] DHCP plugin ... ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where'd you come from? ;-)
Make it explicit that the DHCP daemon being referred to is the one
that's part of the special CNI DHCP plugin.