This repository was archived by the owner on Feb 24, 2020. It is now read-only.
stage0/image: set proxy if InsecureSkipVerify is set #3303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If InsecureSkipVerify is set to true, we skip setting the Proxy argument in http.Transport. This fixes it. Fixes rkt#2590
768c976 to
4990191
Compare
Contributor
|
Great catch! LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If InsecureSkipVerify is set to true, we skip setting the Proxy argument
in http.Transport. This fixes it.
Fixes #2590