-
Notifications
You must be signed in to change notification settings - Fork 881
rkt: gate diagnostic output behind --debug
#3297
Conversation
|
Pushing back a little on silence-as-default: are we concerned about the UX of rkt "hanging" when it's not outputting anything while fetching images etc? |
|
@jonboulle in general yes, this concern exists, which is why we'd better have some verbosity switch at some point. Another concern is that we vendor libraries out of our control, which is way For the specific network fetching case, some bits of image&networking are left untouched here, so for example: |
|
@s-urbaniak @jonboulle ping for a review. I think Jon was mostly concerned about fetching progress, but that shouldn't have changed. |
s-urbaniak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
As discussed oob ideally we would like to inject the lighter, but that is our of scope for this pr. |
|
haha, autocorrection hit me ;) s/lighter/logger |
|
lgtm |
This PR turns off by default all image and networking diagnostic output, moving it behind explicit
--debugflag. This turns an error-free rkt execution from this:into this:
This makes rkt strictly following the UNIX rule of silence, but in the long term we need a better way of handling level/structured logging across all packages and more granular verbosity-switches for CLI (
--verbose=<level>). A complete switch to logrus is being considered, but out of scope here.Fixes #2622