This repository was archived by the owner on Feb 24, 2020. It is now read-only.
cgroup: introduce proper cgroup/v1, cgroup/v2 packages #3277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have func .*V[1|2].* named function names in the cgroup package. This factors those functions into two separate packages cgroup/v1, and cgroup/v2. This is a prerequisite for rkt#3242
Contributor
Author
lucab
reviewed
Oct 13, 2016
| } | ||
| ) | ||
|
|
||
| func mountFsRO(mountPoint string) error { |
Member
There was a problem hiding this comment.
I'm just concerned that this should (also?) take a flags parameter from the outside.
Contributor
Author
There was a problem hiding this comment.
In see MS_STRICTATIME set in https://github.com/coreos/rkt/pull/3277/files#diff-255755d0e4a8ba8def22e94ff6f0c1b6R276 which is not listed here.
Contributor
Author
There was a problem hiding this comment.
Agreed, that this should take flag arguments. I will tackle this in a separate PR.
lucab
approved these changes
Oct 13, 2016
Member
lucab
left a comment
There was a problem hiding this comment.
This cleanup LGTM. I just have a concern on the existing code (which doesn't block this): are we dropping some flags when remounting?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have func .V[1|2]. named function names in the cgroup
package.
This factors those functions into two separate packages cgroup/v1, and
cgroup/v2.
This is a prerequisite for #3242