stage1: followup to limit device node creation/reading/writing #3058
Conversation
Golang's `os.ModeDevice` is enough to detect if a file is a device node.
Shifting doesn't make sense because: 1. The device is not bind-mounted in any location inside the pod. 2. If it were, shifting would affect the host. And we don't want to do that.
| return binPath, nil | ||
| } | ||
|
|
||
| // shiftFiles shifts filesToshift by the amounts specified in uidRange |
There was a problem hiding this comment.
https://twitter.com/baronboulle/status/586278125199351808
On 11 August 2016 at 17:42, Krzesimir Nowak [email protected]
wrote:
In stage1/init/common/pod.go
#3058 (comment):@@ -372,6 +368,18 @@ func findBinPath(p *stage1commontypes.Pod, appName types.ACName, app types.App,
return binPath, nil
}+// shiftFiles shifts filesToshift by the amounts specified in uidRange
Not enough shift.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/coreos/rkt/pull/3058/files/9af924ee0d930eced4806010443e02b920edf158#r74447166,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACewN_rAGK8iVgwNHZfTxd8ZPhwi1FqMks5qe0LVgaJpZM4JiPEk
.
|
Thanks! LGTM |
This is a followup to #3027 fixing some issues raised by a post-merge review.
cc @alban