This repository was archived by the owner on Feb 24, 2020. It is now read-only.
build: Fix make clean for recent systemd version in src flavor #3046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently systemd got some tools written in python, which is executed at the build time. And python being python likes to put the compiled bytecode of the script next to the script itself, which violates my assumption that the srcdir should not change when we perform the build in a different directory. To fix this, we generate the second filelist of the srcdir after the building of systemd finishes and generate a clean file based on the generated filelist.
Member
|
lgtm and it makes debian-src tests not to fail. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently systemd got some tools written in python, which is executed
at the build time. And python being python likes to put the compiled
bytecode of the script next to the script itself, which violates my
assumption that the srcdir should not change when we perform the build
in a different directory.
To fix this, we generate the second filelist of the srcdir after the
building of systemd finishes and generate a clean file based on the
generated filelist.